Skip to content

Commit

Permalink
Replacing the OVERRIDE with override and FINAL with final in /src/gin
Browse files Browse the repository at this point in the history
This step is a giant search and replace for OVERRIDE and FINAL to
replace them with their lowercase versions.

BUG=417463

Review URL: https://codereview.chromium.org/629153002

Cr-Commit-Position: refs/heads/master@{#298220}
  • Loading branch information
anujk.sharma authored and Commit bot committed Oct 6, 2014
1 parent 899fc2d commit e548191
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 18 deletions.
6 changes: 3 additions & 3 deletions gin/array_buffer.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ namespace gin {

class ArrayBufferAllocator : public v8::ArrayBuffer::Allocator {
public:
virtual void* Allocate(size_t length) OVERRIDE;
virtual void* AllocateUninitialized(size_t length) OVERRIDE;
virtual void Free(void* data, size_t length) OVERRIDE;
virtual void* Allocate(size_t length) override;
virtual void* AllocateUninitialized(size_t length) override;
virtual void Free(void* data, size_t length) override;

GIN_EXPORT static ArrayBufferAllocator* SharedInstance();
};
Expand Down
14 changes: 7 additions & 7 deletions gin/interceptor_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class MyInterceptor : public Wrappable<MyInterceptor>,
// gin::NamedPropertyInterceptor
virtual v8::Local<v8::Value> GetNamedProperty(v8::Isolate* isolate,
const std::string& property)
OVERRIDE {
override {
if (property == "value") {
return ConvertToV8(isolate, value_);
} else if (property == "func") {
Expand All @@ -44,15 +44,15 @@ class MyInterceptor : public Wrappable<MyInterceptor>,
}
virtual bool SetNamedProperty(v8::Isolate* isolate,
const std::string& property,
v8::Local<v8::Value> value) OVERRIDE {
v8::Local<v8::Value> value) override {
if (property == "value") {
ConvertFromV8(isolate, value, &value_);
return true;
}
return false;
}
virtual std::vector<std::string> EnumerateNamedProperties(
v8::Isolate* isolate) OVERRIDE {
v8::Isolate* isolate) override {
std::vector<std::string> result;
result.push_back("func");
result.push_back("value");
Expand All @@ -61,14 +61,14 @@ class MyInterceptor : public Wrappable<MyInterceptor>,

// gin::IndexedPropertyInterceptor
virtual v8::Local<v8::Value> GetIndexedProperty(v8::Isolate* isolate,
uint32_t index) OVERRIDE {
uint32_t index) override {
if (index == 0)
return ConvertToV8(isolate, value_);
return v8::Local<v8::Value>();
}
virtual bool SetIndexedProperty(v8::Isolate* isolate,
uint32_t index,
v8::Local<v8::Value> value) OVERRIDE {
v8::Local<v8::Value> value) override {
if (index == 0) {
ConvertFromV8(isolate, value, &value_);
return true;
Expand All @@ -77,7 +77,7 @@ class MyInterceptor : public Wrappable<MyInterceptor>,
return true;
}
virtual std::vector<uint32_t> EnumerateIndexedProperties(v8::Isolate* isolate)
OVERRIDE {
override {
std::vector<uint32_t> result;
result.push_back(0);
return result;
Expand All @@ -93,7 +93,7 @@ class MyInterceptor : public Wrappable<MyInterceptor>,

// gin::Wrappable
virtual ObjectTemplateBuilder GetObjectTemplateBuilder(v8::Isolate* isolate)
OVERRIDE {
override {
return Wrappable<MyInterceptor>::GetObjectTemplateBuilder(isolate)
.AddNamedPropertyInterceptor()
.AddIndexedPropertyInterceptor();
Expand Down
4 changes: 2 additions & 2 deletions gin/run_microtasks_observer.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ class RunMicrotasksObserver : public base::MessageLoop::TaskObserver {
public:
RunMicrotasksObserver(v8::Isolate* isolate);

virtual void WillProcessTask(const base::PendingTask& pending_task) OVERRIDE;
virtual void DidProcessTask(const base::PendingTask& pending_task) OVERRIDE;
virtual void WillProcessTask(const base::PendingTask& pending_task) override;
virtual void DidProcessTask(const base::PendingTask& pending_task) override;

private:
v8::Isolate* isolate_;
Expand Down
6 changes: 3 additions & 3 deletions gin/shell_runner.h
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,12 @@ class GIN_EXPORT ShellRunner : public Runner {

// Runner overrides:
virtual void Run(const std::string& source,
const std::string& resource_name) OVERRIDE;
const std::string& resource_name) override;
virtual v8::Handle<v8::Value> Call(v8::Handle<v8::Function> function,
v8::Handle<v8::Value> receiver,
int argc,
v8::Handle<v8::Value> argv[]) OVERRIDE;
virtual ContextHolder* GetContextHolder() OVERRIDE;
v8::Handle<v8::Value> argv[]) override;
virtual ContextHolder* GetContextHolder() override;

private:
friend class Scope;
Expand Down
6 changes: 3 additions & 3 deletions gin/wrappable_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ class MyObject : public BaseClass,
protected:
MyObject() : value_(0) {}
virtual ObjectTemplateBuilder GetObjectTemplateBuilder(
v8::Isolate* isolate) OVERRIDE;
v8::Isolate* isolate) override;
virtual ~MyObject() {}

private:
Expand All @@ -62,7 +62,7 @@ class MyObjectSubclass : public MyObject {

private:
virtual ObjectTemplateBuilder GetObjectTemplateBuilder(
v8::Isolate* isolate) OVERRIDE {
v8::Isolate* isolate) override {
return MyObject::GetObjectTemplateBuilder(isolate)
.SetMethod("sayHello", &MyObjectSubclass::SayHello);
}
Expand All @@ -86,7 +86,7 @@ class MyCallableObject : public Wrappable<MyCallableObject> {

private:
virtual ObjectTemplateBuilder GetObjectTemplateBuilder(
v8::Isolate* isolate) OVERRIDE {
v8::Isolate* isolate) override {
return Wrappable<MyCallableObject>::GetObjectTemplateBuilder(isolate)
.SetCallAsFunctionHandler(&MyCallableObject::Call);
}
Expand Down

0 comments on commit e548191

Please sign in to comment.