Skip to content

Commit

Permalink
[iOS] Disable failing bookmarks tests
Browse files Browse the repository at this point in the history
The following tests are being disabled on iphone-device:

BookmarksTestCase/testMoveDoesSaveOnSave
BookmarksTestCase/testEmptyBackgroundAndSelectButton
BookmarksTestCase/testBookmarkContextBarInMultipleSelectionModes
BookmarksTestCase/testBookmarkContextBarInSingleSelectionModes
BookmarksTestCase/testKeyboardCommandsNotRegistered_EditBookmark
BookmarksEntriesTestCase/testContextMenuForMixedSelection

TBR= sczs@chromium.org

Bug: 1045966
Change-Id: Idd767cc19e7443825be6f08680813732426770ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020932
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735446}
  • Loading branch information
Javier Ernesto Flores Robles authored and Commit Bot committed Jan 27, 2020
1 parent ed8331a commit e4390a9
Show file tree
Hide file tree
Showing 2 changed files with 42 additions and 0 deletions.
35 changes: 35 additions & 0 deletions ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,13 @@ - (void)testBookmarkMultipleTabs {
// Tests that changes to the parent folder from the Single Bookmark Editor
// are saved to the bookmark only when saving the results.
- (void)testMoveDoesSaveOnSave {
// TODO(crbug.com/1045966): fix for iphone-device and reenable.
#if !TARGET_IPHONE_SIMULATOR
if (![ChromeEarlGrey isIPadIdiom]) {
EARL_GREY_TEST_DISABLED(@"Test disabled on iPhone devices.");
}
#endif

[BookmarkEarlGrey setupStandardBookmarks];
[BookmarkEarlGreyUI openBookmarks];
[BookmarkEarlGreyUI openMobileBookmarks];
Expand Down Expand Up @@ -212,6 +219,13 @@ - (void)testKeyboardCommandsRegistered_AddBookmark {
// Tests that keyboard commands are not registered when a bookmark is edited, as
// the edit screen is presented modally.
- (void)testKeyboardCommandsNotRegistered_EditBookmark {
// TODO(crbug.com/1045966): fix for iphone-device and reenable.
#if !TARGET_IPHONE_SIMULATOR
if (![ChromeEarlGrey isIPadIdiom]) {
EARL_GREY_TEST_DISABLED(@"Test disabled on iPhone devices.");
}
#endif

[BookmarkEarlGrey setupStandardBookmarks];
[BookmarkEarlGreyUI openBookmarks];
[BookmarkEarlGreyUI openMobileBookmarks];
Expand Down Expand Up @@ -314,6 +328,13 @@ - (void)testBookmarkContextBarShown {
}

- (void)testBookmarkContextBarInSingleSelectionModes {
// TODO(crbug.com/1045966): fix for iphone-device and reenable.
#if !TARGET_IPHONE_SIMULATOR
if (![ChromeEarlGrey isIPadIdiom]) {
EARL_GREY_TEST_DISABLED(@"Test disabled on iPhone devices.");
}
#endif

[BookmarkEarlGrey setupStandardBookmarks];
[BookmarkEarlGreyUI openBookmarks];
[BookmarkEarlGreyUI openMobileBookmarks];
Expand Down Expand Up @@ -448,6 +469,13 @@ - (void)testBookmarkContextBarInSingleSelectionModes {
}

- (void)testBookmarkContextBarInMultipleSelectionModes {
// TODO(crbug.com/1045966): fix for iphone-device and reenable.
#if !TARGET_IPHONE_SIMULATOR
if (![ChromeEarlGrey isIPadIdiom]) {
EARL_GREY_TEST_DISABLED(@"Test disabled on iPhone devices.");
}
#endif

[BookmarkEarlGrey setupStandardBookmarks];
[BookmarkEarlGreyUI openBookmarks];
[BookmarkEarlGreyUI openMobileBookmarks];
Expand Down Expand Up @@ -624,6 +652,13 @@ - (void)DISABLED_testNewFolderNameCommittedWhenKeyboardDismissedOnIpad {
testEmptyBackgroundAndSelectButton
#endif
- (void)MAYBE_testEmptyBackgroundAndSelectButton {
// TODO(crbug.com/1045966): fix for iphone-device and reenable.
#if !TARGET_IPHONE_SIMULATOR
if (![ChromeEarlGrey isIPadIdiom]) {
EARL_GREY_TEST_DISABLED(@"Test disabled on iPhone devices.");
}
#endif

[BookmarkEarlGrey setupStandardBookmarks];
[BookmarkEarlGreyUI openBookmarks];
[BookmarkEarlGreyUI openMobileBookmarks];
Expand Down
7 changes: 7 additions & 0 deletions ios/chrome/browser/ui/bookmarks/bookmarks_entries_egtest.mm
Original file line number Diff line number Diff line change
Expand Up @@ -677,6 +677,13 @@ - (void)testOpenSingleBookmarkInNormalAndIncognitoTab {
}

- (void)testContextMenuForMixedSelection {
// TODO(crbug.com/1045966): fix for iphone-device and reenable.
#if !TARGET_IPHONE_SIMULATOR
if (![ChromeEarlGrey isIPadIdiom]) {
EARL_GREY_TEST_DISABLED(@"Test disabled on iPhone devices.");
}
#endif

[BookmarkEarlGrey setupStandardBookmarks];
[BookmarkEarlGreyUI openBookmarks];
[BookmarkEarlGreyUI openMobileBookmarks];
Expand Down

0 comments on commit e4390a9

Please sign in to comment.