Skip to content

Commit

Permalink
Adding deps for //remoting/host/security_key
Browse files Browse the repository at this point in the history
Fixes gn check failures.

The remaining issue is a circular dependency between
host/security_key:security_key and host:common.

Bug: 1159013
Change-Id: Ibd5078abebe093496991d271099e5fa222ad03dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3000818
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#898316}
  • Loading branch information
lilles authored and Chromium LUCI CQ committed Jul 2, 2021
1 parent e1481af commit e0c484d
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .gn
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ no_check_targets = [
"//ppapi/proxy:ipc_sources", # 13 errors
"//ppapi/proxy:proxy", # 5 errors
"//ppapi/thunk:*", # 1071 errors
"//remoting/host/security_key:*", # 68 errors
"//remoting/host/security_key:*", # 10 errors
"//remoting/host/win:*", # 43 errors
"//remoting/ios/app/settings:*", # 6 errors
"//remoting/protocol:*", # 3 errors
Expand Down
15 changes: 15 additions & 0 deletions remoting/host/security_key/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,10 @@ source_set("security_key") {
"//ipc",
"//mojo/public/cpp/platform",
"//mojo/public/cpp/system",
"//net:net",
"//net/traffic_annotation:traffic_annotation",
"//remoting/proto",
"//remoting/protocol:protocol",
"//third_party/webrtc_overrides:webrtc_component",
]

Expand All @@ -62,8 +65,11 @@ source_set("main") {
"remote_security_key_main.h",
]
deps = [
":security_key",
"//base:debugging_buildflags",
"//mojo/core/embedder",
"//remoting/host:base",
"//remoting/host:common",
]
}

Expand Down Expand Up @@ -101,8 +107,16 @@ source_set("unit_tests") {

public_deps = [ ":test_support" ]
deps = [
":security_key",
"//mojo/core/test:test_support",
"//net:net",
"//net:test_support",
"//net/traffic_annotation:test_support",
"//remoting:test_support",
"//remoting/host:common",
"//remoting/host:test_support",
"//remoting/host/setup:common",
"//remoting/protocol:protocol",
]

if (is_posix) {
Expand All @@ -129,6 +143,7 @@ static_library("test_support") {
]

deps = [
":security_key",
"//ipc",
"//remoting/proto",
"//testing/gtest",
Expand Down

0 comments on commit e0c484d

Please sign in to comment.