Skip to content

Commit

Permalink
Shrink APIPermissionInfo from 32b to 24b with better packing
Browse files Browse the repository at this point in the history
ExtensionsClient::DoInitialize is still reported as ~2% of renderer
startup time according to stack sampled metrics. This patch reduces the
size of APIPermissionInfo to reduce malloc.

Bug: 847237
Change-Id: Ib7d4a7156734ff84906925fa38174ece58925844
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807717
Auto-Submit: Philip Rogers <pdr@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697264}
  • Loading branch information
progers authored and Commit Bot committed Sep 17, 2019
1 parent c5b7a08 commit e0a43a1
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
7 changes: 3 additions & 4 deletions extensions/common/permissions/api_permission.cc
Original file line number Diff line number Diff line change
Expand Up @@ -104,11 +104,10 @@ const char* APIPermission::name() const {
//

APIPermissionInfo::APIPermissionInfo(const APIPermissionInfo::InitInfo& info)
: id_(info.id),
name_(info.name),
: name_(info.name),
id_(info.id),
flags_(info.flags),
api_permission_constructor_(info.constructor) {
}
api_permission_constructor_(info.constructor) {}

APIPermissionInfo::~APIPermissionInfo() { }

Expand Down
2 changes: 1 addition & 1 deletion extensions/common/permissions/api_permission.h
Original file line number Diff line number Diff line change
Expand Up @@ -446,8 +446,8 @@ class APIPermissionInfo {

explicit APIPermissionInfo(const InitInfo& info);

const APIPermission::ID id_;
const char* const name_;
const APIPermission::ID id_;
const int flags_;
const APIPermissionConstructor api_permission_constructor_;
};
Expand Down

0 comments on commit e0a43a1

Please sign in to comment.