Skip to content

Commit

Permalink
webview: re-enable SSL tests.
Browse files Browse the repository at this point in the history
Re-enable these to see what errors they report via the newly added
logging, since this failure doesn't seem to be reproducible.

Bug: 1106472
Bug: 1117289
Change-Id: I70c7341a53a0c79a3edf29588ece4fe7d1a06220
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399523
Auto-Submit: Richard Coles <torne@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805434}
  • Loading branch information
tornewuff authored and Commit Bot committed Sep 9, 2020
1 parent fc7c1bd commit de83b74
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

import static org.chromium.android_webview.test.AwActivityTestRule.WAIT_TIMEOUT_MS;

import android.os.Build.VERSION_CODES;
import android.support.test.InstrumentationRegistry;
import android.webkit.JavascriptInterface;

Expand All @@ -24,7 +23,6 @@
import org.chromium.android_webview.AwContentsClient.AwWebResourceRequest;
import org.chromium.android_webview.test.TestAwContentsClient.OnReceivedSslErrorHelper;
import org.chromium.base.BuildInfo;
import org.chromium.base.test.util.DisableIf;
import org.chromium.base.test.util.Feature;
import org.chromium.net.test.EmbeddedTestServer;
import org.chromium.net.test.ServerCertificate;
Expand Down Expand Up @@ -60,8 +58,6 @@ public void setUp() {
@SmallTest
@Feature({"AndroidWebView", "Network"})
// clang-format off
@DisableIf.Build(sdk_is_greater_than = VERSION_CODES.LOLLIPOP_MR1,
sdk_is_less_than = VERSION_CODES.N, hardware_is = "flo")
public void testSHA1LocalAnchorsAllowed() throws Throwable {
// clang-format on
mTestServer = EmbeddedTestServer.createAndStartHTTPSServer(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,9 @@

import org.chromium.android_webview.AwContents;
import org.chromium.android_webview.test.TestAwContentsClient.OnReceivedSslErrorHelper;
import org.chromium.base.test.util.DisableIf;
import org.chromium.base.test.util.Feature;
import org.chromium.net.test.EmbeddedTestServer;
import org.chromium.net.test.ServerCertificate;
import org.chromium.ui.test.util.UiDisableIf;

/**
* SslError tests.
Expand Down Expand Up @@ -50,7 +48,6 @@ public void setUp() {
@Test
@Feature({"AndroidWebView"})
@SmallTest
@DisableIf.Device(type = {UiDisableIf.TABLET}) // See https://crbug.com/1117289.
public void testSslErrorNotCalledForOkCert() throws Throwable {
mTestServer = EmbeddedTestServer.createAndStartHTTPSServer(
InstrumentationRegistry.getInstrumentation().getContext(),
Expand Down

0 comments on commit de83b74

Please sign in to comment.