Skip to content

Commit

Permalink
HID device connection now shared on Linux
Browse files Browse the repository at this point in the history
Remove exclusive flags so that 2 apps can communicate with same device.
This is coherent with Windows and Mac implementation.
Note that a non-chrome app (e.g. desktop app on Windows) can open same
device.

BUG=358631
TBR=rockot@chromium.org

Review URL: https://codereview.chromium.org/213743009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261019 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
jracle@logitech.com committed Apr 2, 2014
1 parent d0064e4 commit d0a4bdb
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
1 change: 1 addition & 0 deletions AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ Joshua Lock <joshua.lock@intel.com>
Joshua Roesslein <jroesslein@gmail.com>
Josué Ratelle <jorat1346@gmail.com>
Juhui Lee <juhui24.lee@samsung.com>
Julien Racle <jracle@logitech.com>
Jun Jiang <jun.a.jiang@intel.com>
Junmin Zhu <junmin.zhu@intel.com>
Kalyan Kondapally <kalyan.kondapally@intel.com>
Expand Down
4 changes: 1 addition & 3 deletions device/hid/hid_connection_linux.cc
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,7 @@ HidConnectionLinux::HidConnectionLinux(HidDeviceInfo device_info,

int flags = base::File::FLAG_OPEN |
base::File::FLAG_READ |
base::File::FLAG_WRITE |
base::File::FLAG_EXCLUSIVE_READ |
base::File::FLAG_EXCLUSIVE_WRITE;
base::File::FLAG_WRITE;

base::File device_file(base::FilePath(dev_node), flags);
if (!device_file.IsValid()) {
Expand Down

0 comments on commit d0a4bdb

Please sign in to comment.