Skip to content

Commit

Permalink
media: Fix double compiling gpu/ipc/common
Browse files Browse the repository at this point in the history
//media/gpu is depending directly on ipc_common_sources which ends up
compiling a separate copy of ipc_common_sources into media_gpu in
component builds. Fix this by depending on the group instead.

This fixes any crashes related to CheckFeatureIdentity failing on
AImageReader in component build.

Fixed: 1144945
Change-Id: Ice2758de77f704103e792242449b985b3937e570
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553969
Commit-Queue: Frank Liberato <liberato@chromium.org>
Auto-Submit: Bo <boliu@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830221}
  • Loading branch information
Bo Liu authored and Commit Bot committed Nov 23, 2020
1 parent 083f751 commit cecc380
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion media/gpu/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ component("gpu") {
"//gpu/ipc/common:android_image_reader_utils",

# TODO(crbug.com/789435): This can be removed once CdmManager is removed.
"//gpu/ipc/common:ipc_common_sources",
"//gpu/ipc/common",
"//media/mojo:buildflags",
"//services/service_manager/public/cpp:cpp",
"//ui/gl:gl_jni_headers",
Expand Down

0 comments on commit cecc380

Please sign in to comment.