Skip to content

Commit

Permalink
Fix outdated comment in install-build-deps.sh.
Browse files Browse the repository at this point in the history
In https://crrev.com/651373, the package_exists() implementation changed
but the comment did not reflect this change.

Change-Id: Ic13e7a3cef28a980ebd167af1bab31006bbf5b59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375928
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#801469}
  • Loading branch information
leizleiz authored and Commit Bot committed Aug 25, 2020
1 parent 6d7a1ad commit cd966ec
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions build/install-build-deps.sh
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ package_exists() {
echo "Call build_apt_package_list() prior to calling package_exists()" >&2
apt_package_list=$(build_apt_package_list)
fi
# 'apt-cache search' takes a regex string, so eg. the +'s in packages like
# "libstdc++" need to be escaped.
# `grep` takes a regex string, so the +'s in package names, e.g. "libstdc++",
# need to be escaped.
local escaped="$(echo $1 | sed 's/[\~\+\.\:-]/\\&/g')"
[ ! -z "$(grep "^${escaped}$" <<< "${apt_package_list}")" ]
}
Expand Down

0 comments on commit cd966ec

Please sign in to comment.