Skip to content

Commit

Permalink
Sheriff: Disable a flaky test on mac
Browse files Browse the repository at this point in the history
Disable flaky GeolocationServiceUnitTest.UrlWithApiKey on mac.

Bug: 1235907
Change-Id: I38ace321ed4d81a9564995646156706963649227
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3069092
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Owners-Override: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#908354}
  • Loading branch information
hayatoito authored and Chromium LUCI CQ committed Aug 4, 2021
1 parent 7227dba commit c7d55d4
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion services/device/geolocation/geolocation_service_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,19 @@ class GeolocationServiceUnitTest : public DeviceServiceTestBase {
DISALLOW_COPY_AND_ASSIGN(GeolocationServiceUnitTest);
};

// GeolocationServiceUnitTest.UrlWithApiKey is flaky on mac
// https://crbug.com/1235907.
#if defined(OS_MAC)
#define MAYBE_UrlWithApiKey DISABLED_UrlWithApiKey
#else
#define MAYBE_UrlWithApiKey UrlWithApiKey
#endif

#if BUILDFLAG(IS_CHROMEOS_ASH) || defined(OS_ANDROID)
// ChromeOS fails to perform network geolocation when zero wifi networks are
// detected in a scan: https://crbug.com/767300.
#else
TEST_F(GeolocationServiceUnitTest, UrlWithApiKey) {
TEST_F(GeolocationServiceUnitTest, MAYBE_UrlWithApiKey) {
// To align with user expectation we do not make Network Location Requests
// on macOS unless the browser has Location Permission from the OS.
#if defined(OS_MAC)
Expand Down

0 comments on commit c7d55d4

Please sign in to comment.