Skip to content

Commit

Permalink
Revert "Disable CQ experiments"
Browse files Browse the repository at this point in the history
This reverts commit 7d7eb2c.

Reason for revert: outage is over

Original change's description:
> Disable CQ experiments
>
> We're having issues with high pending times on the linux CQ pool.
> Disabling this for now, since experiments are optional and are
> currently using up capacity.
>
> No-Presubmit: true
> Bug: 1133410
> Change-Id: I4d34c8a7403249601dfbbdba450b46b97d3ef869
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438672
> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> Commit-Queue: Erik Staab <estaab@chromium.org>
> Auto-Submit: Stephen Martinis <martiniss@chromium.org>
> Reviewed-by: Erik Staab <estaab@chromium.org>
> Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#811773}

TBR=estaab@chromium.org,martiniss@chromium.org,gbeaty@chromium.org

Change-Id: Iba64cf556a302342d58dc207072ef8f05b868096
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1133410
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441020
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812216}
  • Loading branch information
martiniss authored and Commit Bot committed Sep 30, 2020
1 parent 192ad9f commit c49eaa0
Show file tree
Hide file tree
Showing 3 changed files with 36 additions and 12 deletions.
44 changes: 36 additions & 8 deletions infra/config/generated/commit-queue.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,10 @@ config_groups {
}
builders {
name: "chromium/try/android-marshmallow-x86-rel"
includable_only: true
experiment_percentage: 20
location_regexp: ".*"
location_regexp_exclude: ".+/[+]/docs/.+"
location_regexp_exclude: ".+/[+]/infra/config/.+"
}
builders {
name: "chromium/try/android-marshmallow-x86-rel-non-cq"
Expand Down Expand Up @@ -282,7 +285,10 @@ config_groups {
}
builders {
name: "chromium/try/android-pie-arm64-rel"
includable_only: true
experiment_percentage: 60
location_regexp: ".*"
location_regexp_exclude: ".+/[+]/docs/.+"
location_regexp_exclude: ".+/[+]/infra/config/.+"
}
builders {
name: "chromium/try/android-pie-arm64-wpt-rel-non-cq"
Expand Down Expand Up @@ -572,7 +578,10 @@ config_groups {
}
builders {
name: "chromium/try/fuchsia-compile-x64-dbg"
includable_only: true
experiment_percentage: 50
location_regexp: ".*"
location_regexp_exclude: ".+/[+]/docs/.+"
location_regexp_exclude: ".+/[+]/infra/config/.+"
}
builders {
name: "chromium/try/fuchsia-fyi-arm64-dbg"
Expand Down Expand Up @@ -884,7 +893,10 @@ config_groups {
}
builders {
name: "chromium/try/ios-simulator-code-coverage"
includable_only: true
experiment_percentage: 3
location_regexp: ".*"
location_regexp_exclude: ".+/[+]/docs/.+"
location_regexp_exclude: ".+/[+]/infra/config/.+"
}
builders {
name: "chromium/try/ios-simulator-cr-recipe"
Expand Down Expand Up @@ -1051,7 +1063,14 @@ config_groups {
}
builders {
name: "chromium/try/linux-perfetto-rel"
includable_only: true
experiment_percentage: 100
location_regexp: ".+/[+]/base/trace_event/.+"
location_regexp: ".+/[+]/base/tracing/.+"
location_regexp: ".+/[+]/components/tracing/.+"
location_regexp: ".+/[+]/content/browser/tracing/.+"
location_regexp: ".+/[+]/services/tracing/.+"
location_regexp_exclude: ".+/[+]/docs/.+"
location_regexp_exclude: ".+/[+]/infra/config/.+"
}
builders {
name: "chromium/try/linux-rel"
Expand All @@ -1061,7 +1080,10 @@ config_groups {
}
builders {
name: "chromium/try/linux-rel-builderful"
includable_only: true
experiment_percentage: 10
location_regexp: ".*"
location_regexp_exclude: ".+/[+]/docs/.+"
location_regexp_exclude: ".+/[+]/infra/config/.+"
}
builders {
name: "chromium/try/linux-swangle-chromium-try-x64"
Expand Down Expand Up @@ -1265,7 +1287,10 @@ config_groups {
}
builders {
name: "chromium/try/mac-coverage-rel"
includable_only: true
experiment_percentage: 8
location_regexp: ".*"
location_regexp_exclude: ".+/[+]/docs/.+"
location_regexp_exclude: ".+/[+]/infra/config/.+"
}
builders {
name: "chromium/try/mac-dawn-rel"
Expand Down Expand Up @@ -1844,7 +1869,10 @@ config_groups {
}
builders {
name: "chromium/try-m85/fuchsia_arm64"
includable_only: true
experiment_percentage: 50
location_regexp: ".*"
location_regexp_exclude: ".+/[+]/docs/.+"
location_regexp_exclude: ".+/[+]/infra/config/.+"
}
builders {
name: "chromium/try-m85/fuchsia_x64"
Expand Down
3 changes: 0 additions & 3 deletions infra/config/generated/cq-builders.md
Original file line number Diff line number Diff line change
Expand Up @@ -347,9 +347,6 @@ These builders are run on some percentage of builds. Their results are ignored
by CQ. These are often used to test new configurations before they are added
as required builders.

These builders are currently disabled due to the cq_disable_experiments outages
setting. See //infra/config/outages/README.md for more information.

* [android-marshmallow-x86-rel](https://ci.chromium.org/p/chromium/builders/try/android-marshmallow-x86-rel) ([definition](https://cs.chromium.org/search?q=package:%5Echromium$+file:/cq.star$+-file:/beta/+-file:/stable/+android-marshmallow-x86-rel)) ([matching builders](https://cs.chromium.org/search?q=+file:trybots.py+android-marshmallow-x86-rel))
* Experiment percentage: 20

Expand Down
1 change: 0 additions & 1 deletion infra/config/outages/config.star
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,4 @@ def _outages_config(*, disable_cq_experiments = False):

# See README.md for documentation on allowable configuration values
config = _outages_config(
disable_cq_experiments = True,
)

0 comments on commit c49eaa0

Please sign in to comment.