Skip to content

Commit

Permalink
sql: Enable disabled tests in RecoverModuleTest.
Browse files Browse the repository at this point in the history
https://crrev.com/c/3015299 removed the incorrect DCHECKs that were
blocking these tests.

Change-Id: I6510c39d910e57e2e19e1933b153d120e994ff97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3035423
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Auto-Submit: Victor Costan <pwnall@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#902750}
  • Loading branch information
pwnall authored and Chromium LUCI CQ committed Jul 17, 2021
1 parent 5c84019 commit c108149
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions sql/recover_module/module_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -78,13 +78,11 @@ TEST_F(RecoverModuleTest, CreateVtableFailsOnMissingTable) {
EXPECT_TRUE(error_expecter.SawExpectedErrors());
}
}
TEST_F(RecoverModuleTest, DISABLED_CreateVtableFailsOnMissingDatabase) {
// TODO(pwnall): Enable test after removing incorrect DLOG(FATAL) from
// sql::Statement::Execute().
TEST_F(RecoverModuleTest, CreateVtableFailsOnMissingDatabase) {
ASSERT_TRUE(db_.Execute("CREATE TABLE backing(t TEXT)"));
{
sql::test::ScopedErrorExpecter error_expecter;
error_expecter.ExpectError(SQLITE_ERROR);
error_expecter.ExpectError(SQLITE_CORRUPT);
EXPECT_FALSE(
db_.Execute("CREATE VIRTUAL TABLE temp.recover_backing "
"USING recover(db.backing, t TEXT)"));
Expand All @@ -102,13 +100,11 @@ TEST_F(RecoverModuleTest, CreateVtableFailsOnTableWithInvalidQualifier) {
EXPECT_TRUE(error_expecter.SawExpectedErrors());
}
}
TEST_F(RecoverModuleTest, DISABLED_CreateVtableFailsOnMissingTableName) {
// TODO(pwnall): Enable test after removing incorrect DLOG(FATAL) from
// sql::Statement::Execute().
TEST_F(RecoverModuleTest, CreateVtableFailsOnMissingTableName) {
ASSERT_TRUE(db_.Execute("CREATE TABLE backing(t TEXT)"));
{
sql::test::ScopedErrorExpecter error_expecter;
error_expecter.ExpectError(SQLITE_ERROR);
error_expecter.ExpectError(SQLITE_MISUSE);
EXPECT_FALSE(
db_.Execute("CREATE VIRTUAL TABLE temp.recover_backing "
"USING recover(main., t TEXT)"));
Expand Down

0 comments on commit c108149

Please sign in to comment.