Skip to content

Commit

Permalink
base: disable RepeatedWillBlockDoesNotCreateTooManyWorkers
Browse files Browse the repository at this point in the history
This test is flaky, I think by design.

Bug: 1140651
Change-Id: I4f60d97b8fcc553407b33a260e91f1004615e88e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488398
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819361}
  • Loading branch information
Elly Fong-Jones authored and Commit Bot committed Oct 21, 2020
1 parent af7ebe9 commit b9c3456
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion base/task/thread_pool/thread_group_impl_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1770,8 +1770,9 @@ class HoldWorkersObserver : public WorkerThreadObserver {
// 4. Task A enters a second WILL_BLOCK ScopedBlockingCall. This should no-op
// because there are already enough workers.
// 5. Unblock HoldWorkersObserver and wait for all tasks to complete.
// Disabled: https://crbug.com/1140651
TEST_F(ThreadGroupImplImplStartInBodyTest,
RepeatedWillBlockDoesNotCreateTooManyWorkers) {
DISABLED_RepeatedWillBlockDoesNotCreateTooManyWorkers) {
constexpr size_t kNumWorkers = 2U;
HoldWorkersObserver worker_observer;
StartThreadGroup(TimeDelta::Max(), // |suggested_reclaim_time|
Expand Down

0 comments on commit b9c3456

Please sign in to comment.