Skip to content

Commit

Permalink
Fix some instances of -Wfinal-dtor-non-final-class: services/
Browse files Browse the repository at this point in the history
Bug: 999886
Change-Id: I933602c380c035ba7efc7eac0cc8c1c07fa054ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3058688
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#906787}
  • Loading branch information
pkasting authored and Chromium LUCI CQ committed Jul 29, 2021
1 parent 3959b09 commit b81b778
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions services/audio/output_controller_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -269,13 +269,13 @@ class MockSnooper : public Snoopable::Snooper {

// A FakeAudioManager that produces MockAudioOutputStreams, and tracks the last
// stream that was created and the last stream that was closed.
class AudioManagerForControllerTest : public media::FakeAudioManager {
class AudioManagerForControllerTest final : public media::FakeAudioManager {
public:
AudioManagerForControllerTest()
: media::FakeAudioManager(std::make_unique<media::TestAudioThread>(false),
&fake_audio_log_factory_) {}

~AudioManagerForControllerTest() final = default;
~AudioManagerForControllerTest() override = default;

MockAudioOutputStream* last_created_stream() const {
return last_created_stream_;
Expand Down
4 changes: 2 additions & 2 deletions services/audio/public/cpp/output_device_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -95,10 +95,10 @@ class MockAudioOutputIPC : public media::AudioOutputIPC {
MOCK_METHOD1(SetVolume, void(double volume));
};

class FakeOutputStreamFactory : public audio::FakeStreamFactory {
class FakeOutputStreamFactory final : public audio::FakeStreamFactory {
public:
FakeOutputStreamFactory() : stream_(), stream_receiver_(&stream_) {}
~FakeOutputStreamFactory() final {}
~FakeOutputStreamFactory() override {}

void CreateOutputStream(
mojo::PendingReceiver<media::mojom::AudioOutputStream> stream_receiver,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@ class LoaderLockSampler;
// being held. This is a dedicated thread, instead of using the ThreadPool, so
// that there's never a chance of the lock being sampled from a thread that
// runs other code that takes the lock.
class COMPONENT_EXPORT(TRACING_CPP) LoaderLockSamplingThread
class COMPONENT_EXPORT(TRACING_CPP) LoaderLockSamplingThread final
: public base::Thread {
public:
LoaderLockSamplingThread();
~LoaderLockSamplingThread() final;
~LoaderLockSamplingThread() override;

LoaderLockSamplingThread(const LoaderLockSamplingThread& other) = delete;
LoaderLockSamplingThread& operator=(const LoaderLockSamplingThread& other) =
Expand Down

0 comments on commit b81b778

Please sign in to comment.