Fixed the "My Bookmarks" sample extension.

Stopped referencing a broken jqueryui URL for css and started using a resource hosted at ajax.googleapis.com. Also replaced some single quotes with double quotes. This was causing a parse error since the single quotes where inside another string delineated with single quotes. Patch from Sam McDonald <sam@sammcd.com> BUG=70072 TEST=Load bookmarks extension into a browser. Check that no errors appear in inspector. Click edit on a bookmark to makes sure UI css looks right. Review URL: http://codereview.chromium.org/6447010 Patch from Sam McDonald <sam@sammcd.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74137 0039d316-1c4b-4281-b951-d872f2087c98
FairyWorld · Feb 8, 2011 · b5cf91c · b5cf91c
1 parent 460440c
commit b5cf91c
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/AUTHORS b/AUTHORS
@@ -91,3 +91,4 @@ Sevan Janiyan <venture37@geeklan.co.uk>
 Peter Beverloo <peter@lvp-media.com>
 Lauri Oherd <lauri.oherd@gmail.com>
 Ben Karel <eschew@gmail.com>
+Sam McDonald <sam@sammcd.com>
diff --git a/chrome/common/extensions/docs/examples/api/bookmarks/basic.zip b/chrome/common/extensions/docs/examples/api/bookmarks/basic.zip
diff --git a/chrome/common/extensions/docs/examples/api/bookmarks/basic/popup.html b/chrome/common/extensions/docs/examples/api/bookmarks/basic/popup.html
@@ -1,6 +1,6 @@
 <html>
 <head>
-<link type="text/css" href="http://jqueryui.com/themes/base/ui.all.css" rel="stylesheet">
+<link type="text/css" href="http://ajax.googleapis.com/ajax/libs/jqueryui/1.7.2/themes/base/jquery-ui.css" rel="stylesheet">
 <style>
 div, td, th { color: black; }
 </style>
@@ -48,7 +48,7 @@
       });
       var span = $('<span>');
       var options = bookmarkNode.children ?
-        $('<span>[<a href="#" id='addlink'>Add</a>]</span>') :
+        $('<span>[<a href="#" id="addlink">Add</a>]</span>') :
         $('<span>[<a id="editlink" href="#">Edit</a> <a id="deletelink" ' +
           'href="#">Delete</a>]</span>');
       var edit = bookmarkNode.children ? $('<table><tr><td>Name</td><td>' +

diff --git a/chrome/common/extensions/docs/samples.json b/chrome/common/extensions/docs/samples.json
@@ -1072,7 +1072,7 @@
         "manifest.json", 
         "popup.html"
       ], 
-      "source_hash": "4f7509c56c2943cf8aedf1ee0b4b4a7d1e49f7d3", 
+      "source_hash": "5fd4c8e159a36d2462e9691db12d77a27684d6b7", 
       "zip_path": "examples/api/bookmarks/basic.zip"
     }, 
     {