Skip to content

Commit

Permalink
Added new and fixed some flaky autofill tests
Browse files Browse the repository at this point in the history
Disabled flaky password test of sign_in_pass/marriott with bug number.

Added 6 new sites for autofill that had previously failed during record:
abebooks
bhphotovideo
bloomingdales
hayneedle
sears
vans

Minor test recipe file updates to stabilize 4 flaky tests:
catch
north_face
findmeagift
aeropostale

Updated cipd version for autofill to include new wpr/test files

Bug: 984662,984664,1016437
Change-Id: I04957c4fa5d46bd1f7d57f00dfd746146ba213a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874201
Auto-Submit: Ian Struiksma <ianstruiksma@google.com>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708368}
  • Loading branch information
Ian Struiksma authored and Commit Bot committed Oct 22, 2019
1 parent 7ff572e commit a59116e
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
2 changes: 1 addition & 1 deletion DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,7 @@ deps = {
'packages': [
{
'package': 'chromium/chrome/test/data/autofill/captured_sites',
'version': 'qXyuiSemC7BA9Rtoa77IjWhCD8arKt968jVmHDt34hQC',
'version': '23EuJes_tRa4KkcqAuvDc48MlYCQwVKmjv64tpGllr8C',
}
],
'condition': 'checkout_chromium_autofill_test_dependencies',
Expand Down
6 changes: 6 additions & 0 deletions chrome/test/data/autofill/captured_sites/testcases.json
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,12 @@
{ "site_name": "tractorsupply" },
{ "site_name": "tradesy", "expectation":"PASS" },
{ "site_name": "walmart_ca", "expectation":"PASS" },
{ "site_name": "abebooks", "expectation":"PASS" },
{ "site_name": "bhphotovideo", "expectation":"PASS" },
{ "site_name": "bloomingdales", "expectation":"PASS" },
{ "site_name": "hayneedle", "expectation":"PASS" },
{ "site_name": "sears", "expectation":"PASS" },
{ "site_name": "vans", "expectation":"PASS" },
{ "site_name": "worldmarket", "expectation":"PASS", "disabled":true, "bug_number":1006322 }
]
}
2 changes: 1 addition & 1 deletion chrome/test/data/password/captured_sites/testcases.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
{ "scenario_dir":"sign_in_pass", "site_name":"instagram" },
{ "scenario_dir":"sign_in_pass", "site_name":"kakao" },
{ "scenario_dir":"sign_in_pass", "site_name":"librus" },
{ "scenario_dir":"sign_in_pass", "site_name":"marriott" },
{ "scenario_dir":"sign_in_pass", "site_name":"marriott", "disabled":true, "bug_number":984662 },
{ "scenario_dir":"sign_in_pass", "site_name":"mit" },
{ "scenario_dir":"sign_in_pass", "site_name":"naukri" },
{ "scenario_dir":"sign_in_pass", "site_name":"nexon" },
Expand Down

0 comments on commit a59116e

Please sign in to comment.