Skip to content

Commit

Permalink
Remove VizForWebView feature
Browse files Browse the repository at this point in the history
Feature has launched, this is first step of removing old code.

Bug: 805739, 1202777
Change-Id: I36ba5106723a7e26f29109b89d072fdbb27783a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2850436
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#876261}
  • Loading branch information
vasilyt authored and Chromium LUCI CQ committed Apr 26, 2021
1 parent de55e97 commit 9bcb92e
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 32 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,13 @@ private ProductionSupportedFlagList() {}
+ "(cookies without a SameSite attribute are treated as SameSite=Lax); "
+ "2) Schemeful Same-Site (site boundaries include the URL scheme)."),
Flag.baseFeature(GpuFeatures.WEBVIEW_VULKAN,
"Use Vulkan for composite. Requires VizForWebView and Android device and "
+ "OS support. May crash if enabled on unsupported device."),
"Use Vulkan for composite. Requires Android device and OS support. May crash "
+ "if enabled on unsupported device."),
Flag.baseFeature(GpuFeatures.WEBVIEW_SURFACE_CONTROL,
"Use SurfaceControl. Requires VizForWebView, WebViewZeroCopyVideo and Android "
+ "device and OS support."),
"Use SurfaceControl. Requires WebViewZeroCopyVideo and Android device and OS "
+ "support."),
Flag.baseFeature(GpuFeatures.WEBVIEW_ZERO_COPY_VIDEO,
"Avoid extra copy for video frames when possible"),
Flag.baseFeature(VizFeatures.VIZ_FOR_WEBVIEW, "Enables Viz for WebView."),
Flag.baseFeature(
VizFeatures.WEBVIEW_VULKAN_INTERMEDIATE_BUFFER, "For debugging vulkan"),
Flag.baseFeature(
Expand Down
11 changes: 0 additions & 11 deletions components/viz/common/features.cc
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,6 @@ const base::Feature kDynamicColorGamut{"DynamicColorGamut",
const base::Feature kFastSolidColorDraw{"FastSolidColorDraw",
base::FEATURE_DISABLED_BY_DEFAULT};

// Viz for WebView architecture.
const base::Feature kVizForWebView{"VizForWebView",
base::FEATURE_DISABLED_BY_DEFAULT};

// We use this feature for default value, because enabled VizForWebView forces
// skia renderer on and we want to have different feature state between webview
// and chrome. This one is set by webview, while the above can be set via finch.
Expand Down Expand Up @@ -201,13 +197,6 @@ bool IsUsingVizForWebView() {
if (features::IsUsingVulkan())
return true;

// If the feature is overridden from command line or finch we will use this
// value. If not we check for different state that is altered in
// aw_main_delegate.cc.
base::FeatureList* feature_list = base::FeatureList::GetInstance();
if (feature_list && feature_list->IsFeatureOverridden(kVizForWebView.name))
return base::FeatureList::IsEnabled(kVizForWebView);

return base::FeatureList::IsEnabled(kVizForWebViewDefault);
}

Expand Down
16 changes: 0 additions & 16 deletions testing/variations/fieldtrial_testing_config.json
Original file line number Diff line number Diff line change
Expand Up @@ -7522,22 +7522,6 @@
]
}
],
"VizForWebView": [
{
"platforms": [
"android_webview"
],
"experiments": [
{
"name": "Enabled",
"enable_features": [
"EnableSharedImageForWebview",
"VizForWebView"
]
}
]
}
],
"VizGLFastSolidColorDraw": [
{
"platforms": [
Expand Down

0 comments on commit 9bcb92e

Please sign in to comment.