Skip to content

Commit

Permalink
test server: be much more verbose in logging
Browse files Browse the repository at this point in the history
So far the linked bug has resisted reproduction outside of the bots;
unconditionally log more state to help debug.

Bug: 922068
Change-Id: Ia2d93a1cfc03c1ea2fb1055d3b9cfea764a85217
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592682
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656380}
  • Loading branch information
Elly Fong-Jones authored and Commit Bot committed May 3, 2019
1 parent 14bd786 commit 971a6d4
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions net/test/spawned_test_server/local_test_server_posix.cc
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,8 @@ bool LocalTestServer::LaunchPython(

// Log is useful in the event you want to run a nearby script (e.g. a test) in
// the same environment as the TestServer.
VLOG(1) << "LaunchPython called with PYTHONPATH = "
<< options.environment["PYTHONPATH"];
LOG(ERROR) << "LaunchPython called with PYTHONPATH = "
<< options.environment["PYTHONPATH"];

// Set CWD to source root.
if (!base::PathService::Get(base::DIR_SOURCE_ROOT,
Expand All @@ -150,6 +150,7 @@ bool LocalTestServer::LaunchPython(
}

options.fds_to_remap.push_back(std::make_pair(pipefd[1], pipefd[1]));
LOG(ERROR) << "Running: " << python_command.GetCommandLineString();
process_ = base::LaunchProcess(python_command, options);
if (!process_.IsValid()) {
LOG(ERROR) << "Failed to launch " << python_command.GetCommandLineString();
Expand Down

0 comments on commit 971a6d4

Please sign in to comment.