[Extensions Bindings] Consolidate app hooks methods

Move AppBindingsCore's functionality into AppHooksDelegate. When we had JS and native bindings, we needed to share this code; now that we only have native bindings, the AppHooksDelegate is the only consumer. This is mostly copy-paste, but has a few differences since AppBindingsCore handled sending IPC messages to the browser (this is now handled by a helper object in AppHooksDelegate). Also delete AppBindings, the old C++ handlers for the JS code. Bug: 938998 Change-Id: Ie44a75c523c60b45417610c19e04299047b8121a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535237 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#645137}
FairyWorld · Mar 28, 2019 · 9063ba2 · 9063ba2
1 parent a2daa74
commit 9063ba2
Show file tree

Hide file tree

Showing 8 changed files with 191 additions and 350 deletions.
diff --git a/chrome/renderer/BUILD.gn b/chrome/renderer/BUILD.gn
@@ -276,10 +276,6 @@ jumbo_static_library("renderer") {
 
   if (enable_extensions) {
     sources += [
-      "extensions/app_bindings.cc",
-      "extensions/app_bindings.h",
-      "extensions/app_bindings_core.cc",
-      "extensions/app_bindings_core.h",
       "extensions/app_hooks_delegate.cc",
       "extensions/app_hooks_delegate.h",
       "extensions/automation_ax_tree_wrapper.cc",

diff --git a/chrome/renderer/extensions/app_bindings.cc b/chrome/renderer/extensions/app_bindings.cc
diff --git a/chrome/renderer/extensions/app_bindings.h b/chrome/renderer/extensions/app_bindings.h
diff --git a/chrome/renderer/extensions/app_bindings_core.cc b/chrome/renderer/extensions/app_bindings_core.cc
diff --git a/chrome/renderer/extensions/app_bindings_core.h b/chrome/renderer/extensions/app_bindings_core.h