Skip to content

Commit

Permalink
DevTools: Make the 'Add Watch' button work with a keyboard
Browse files Browse the repository at this point in the history
The watches panel asynchronously shows the pane when a new watch is
added, but the panel must be showing before creating the editor
otherwise focus will not be moved properly.

Bug: 809908
Change-Id: Ieaf3805f937557a07f8554ede60bd3df8820ec0f
Reviewed-on: https://chromium-review.googlesource.com/1077652
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562701}
  • Loading branch information
JoelEinbinder authored and Commit Bot committed May 30, 2018
1 parent 62628bf commit 7fc4fd1
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ Sources.WatchExpressionsSidebarPane = class extends UI.ThrottledWidget {
this._watchExpressionsSetting.set(toSave);
}

_addButtonClicked() {
UI.viewManager.showView('sources.watch');
async _addButtonClicked() {
await UI.viewManager.showView('sources.watch');
this._createWatchExpression(null).startEditing();
}

Expand Down

0 comments on commit 7fc4fd1

Please sign in to comment.