Skip to content

Commit

Permalink
Revert "Suppress video WebGL tests on Android passthrough"
Browse files Browse the repository at this point in the history 
This reverts commit 6032b1c.

Reason for revert: breakage reverted

Original change's description:
> Suppress video WebGL tests on Android passthrough
>
> Bug: 1205418
> Change-Id: I432b81764cf7814dd22b66f7bb225d3712fd59c0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2876446
> Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#879686}

Bug: 1205418
Change-Id: Ib4fb07ca1ee01b69220da475d42fdab9beb5694a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2878181
Auto-Submit: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#880191}
  • Loading branch information
@y-novikov
y-novikov authored and Chromium LUCI CQ committed May 7, 2021
1 parent a9e6b58 commit 76d5183
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 38 deletions.
25 changes: 7 additions & 18 deletions content/test/gpu/gpu_tests/test_expectations/webgl2_conformance_expectations.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ crbug.com/735483 conformance2/rendering/texture-switch-performance.html [ Skip ]
crbug.com/979444 [ linux ] conformance/textures/misc/texture-corner-case-videos.html [ RetryOnFailure ]
crbug.com/979444 [ mac no-asan no-passthrough ] conformance/textures/misc/texture-corner-case-videos.html [ RetryOnFailure ]
crbug.com/979444 [ win ] conformance/textures/misc/texture-corner-case-videos.html [ RetryOnFailure ]
crbug.com/979444 [ android angle-disabled no-passthrough ] conformance/textures/misc/texture-corner-case-videos.html [ RetryOnFailure ]
crbug.com/979444 [ android angle-disabled ] conformance/textures/misc/texture-corner-case-videos.html [ RetryOnFailure ]

# Flaky timeouts on Intel Windows, Linux and Mac
crbug.com/1085222 [ win10 intel-0x3e92 ] deqp/functional/gles3/shaderoperator/binary_operator_* [ Failure ]
Expand Down Expand Up @@ -631,21 +631,10 @@ crbug.com/1152590 [ linux amd-0x7340 no-passthrough ] deqp/functional/gles3/inte
[ android qualcomm ] WebglExtension_WEBGL_compressed_texture_s3tc_srgb [ Skip ]

# Video tests are flaky. Sometimes the video is black.
crbug.com/948894 [ android no-passthrough ] conformance/textures/video/* [ RetryOnFailure ]
crbug.com/948894 [ android no-passthrough ] conformance/textures/image_bitmap_from_video/* [ RetryOnFailure ]
crbug.com/948894 [ android no-passthrough ] conformance2/textures/video/* [ RetryOnFailure ]
crbug.com/948894 [ android no-passthrough ] conformance2/textures/image_bitmap_from_video/* [ RetryOnFailure ]

# These video tests crash on passthrough Pixel 2 and Pixel 4
crbug.com/1205418 [ android passthrough ] conformance/extensions/oes-texture-float-with-video.html [ Failure ]
crbug.com/1205418 [ android passthrough ] conformance/textures/image_bitmap_from_video/* [ Failure ]
crbug.com/1205418 [ android passthrough ] conformance/textures/misc/tex-video-using-tex-unit-non-zero.html [ Failure ]
crbug.com/1205418 [ android passthrough ] conformance/textures/misc/texture-corner-case-videos.html [ Failure ]
crbug.com/1205418 [ android passthrough ] conformance/textures/misc/texture-npot-video.html [ Failure ]
crbug.com/1205418 [ android passthrough ] conformance/textures/misc/video-rotation.html [ Failure ]
crbug.com/1205418 [ android passthrough ] conformance/textures/video/* [ Failure ]
crbug.com/1205418 [ android passthrough ] conformance2/textures/image_bitmap_from_video/* [ Failure ]
crbug.com/1205418 [ android passthrough ] conformance2/textures/video/* [ Failure ]
crbug.com/948894 [ android ] conformance/textures/video/* [ RetryOnFailure ]
crbug.com/948894 [ android ] conformance/textures/image_bitmap_from_video/* [ RetryOnFailure ]
crbug.com/948894 [ android ] conformance2/textures/video/* [ RetryOnFailure ]
crbug.com/948894 [ android ] conformance2/textures/image_bitmap_from_video/* [ RetryOnFailure ]

crbug.com/angleproject/4417 [ android ] conformance2/rendering/framebuffer-render-to-layer.html [ Failure ]

Expand Down Expand Up @@ -710,13 +699,13 @@ crbug.com/1175233 [ android android-pixel-4 no-passthrough ] deqp/functional/gle
crbug.com/1179432 [ android android-pixel-4 angle-disabled no-passthrough ] deqp/functional/gles3/texturespecification/basic_teximage2d_2d_01.html [ RetryOnFailure ]
crbug.com/1179432 [ android android-pixel-4 angle-disabled no-passthrough ] deqp/functional/gles3/transformfeedback/* [ RetryOnFailure ]

crbug.com/1191030 [ android android-pixel-4 no-passthrough ] conformance/textures/misc/video-rotation.html [ Failure ]
crbug.com/1191030 [ android android-pixel-4 ] conformance/textures/misc/video-rotation.html [ Failure ]

# Android ANGLE GLES
# TODO(crbug.com/979444): once this is passing on the passthrough
# command decoder, simplify the RetryOnFailure expectation at the top
# of this file to just not declare any OS.
# crbug.com/979444 [ android angle-opengles ] conformance/textures/misc/texture-corner-case-videos.html [ Failure ]
crbug.com/979444 [ android angle-opengles ] conformance/textures/misc/texture-corner-case-videos.html [ Failure ]

crbug.com/angleproject/3684 [ android angle-opengles ] conformance2/renderbuffers/multisample-with-full-sample-counts.html [ Failure ]
crbug.com/967410 [ android angle-opengles ] conformance2/textures/misc/npot-video-sizing.html [ Failure ]
Expand Down
31 changes: 11 additions & 20 deletions content/test/gpu/gpu_tests/test_expectations/webgl_conformance_expectations.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -551,34 +551,25 @@ crbug.com/352645 [ android ] conformance/textures/video/tex-2d-rgb-rgb-unsigned_
crbug.com/352645 [ android android-webview-instrumentation ] conformance/textures/video/tex-2d-rgba-rgba-unsigned_byte.html [ Skip ]
crbug.com/352645 [ android android-webview-instrumentation ] conformance/textures/video/tex-2d-rgba-rgba-unsigned_short_4_4_4_4.html [ Skip ]
crbug.com/352645 [ android android-webview-instrumentation ] conformance/textures/video/tex-2d-rgba-rgba-unsigned_short_5_5_5_1.html [ Skip ]
crbug.com/352645 [ android android-webview-instrumentation angle-disabled no-passthrough ] conformance/textures/misc/texture-npot-video.html [ Skip ]
crbug.com/352645 [ android android-webview-instrumentation angle-disabled ] conformance/textures/misc/texture-npot-video.html [ Skip ]

# These video tests appear to be flaky.
# TODO(crbug.com/1178518): This crbug caused the test to fail consistently. It
# should be probably back to flaky once the bug is fixed. So uncomment below test once the bug is fixed.
# crbug.com/834933 [ android android-chromium ] conformance/textures/video/tex-2d-rgba-rgba-unsigned_short_4_4_4_4.html [ RetryOnFailure ]
crbug.com/733599 [ android angle-disabled no-passthrough ] conformance/textures/video/tex-2d-luminance_alpha-luminance_alpha-unsigned_byte.html [ RetryOnFailure ]
crbug.com/733599 [ android angle-disabled no-passthrough ] conformance/textures/video/tex-2d-luminance-luminance-unsigned_byte.html [ RetryOnFailure ]
crbug.com/733599 [ android angle-disabled ] conformance/textures/video/tex-2d-luminance_alpha-luminance_alpha-unsigned_byte.html [ RetryOnFailure ]
crbug.com/733599 [ android angle-disabled ] conformance/textures/video/tex-2d-luminance-luminance-unsigned_byte.html [ RetryOnFailure ]
# TODO(crbug.com/1178518): This crbug caused the test to fail consistently. It
# should be probably back to flaky once the bug is fixed. So uncomment below test once the bug is fixed.
# crbug.com/834933 [ android android-chromium ] conformance/textures/video/tex-2d-rgb-rgb-unsigned_byte.html [ RetryOnFailure ]
crbug.com/834933 [ android android-chromium no-passthrough ] conformance/textures/video/tex-2d-rgba-rgba-unsigned_byte.html [ RetryOnFailure ]
crbug.com/891456 [ android no-passthrough ] conformance/textures/image_bitmap_from_video/tex-2d-rgba-rgba-unsigned_short_5_5_5_1.html [ RetryOnFailure ]

# These video tests crash on passthrough Nexus 5X, Shield TV, Pixel 2 and Pixel 4
crbug.com/1205418 [ android passthrough ] conformance/extensions/oes-texture-float-with-video.html [ Failure ]
crbug.com/1205418 [ android passthrough ] conformance/textures/image_bitmap_from_video/* [ Failure ]
crbug.com/1205418 [ android passthrough ] conformance/textures/misc/tex-video-using-tex-unit-non-zero.html [ Failure ]
crbug.com/1205418 [ android passthrough ] conformance/textures/misc/texture-corner-case-videos.html [ Failure ]
crbug.com/1205418 [ android passthrough ] conformance/textures/misc/texture-npot-video.html [ Failure ]
crbug.com/1205418 [ android passthrough ] conformance/textures/misc/video-rotation.html [ Failure ]
crbug.com/1205418 [ android passthrough ] conformance/textures/video/* [ Failure ]
crbug.com/834933 [ android android-chromium ] conformance/textures/video/tex-2d-rgba-rgba-unsigned_byte.html [ RetryOnFailure ]
crbug.com/891456 [ android ] conformance/textures/image_bitmap_from_video/tex-2d-rgba-rgba-unsigned_short_5_5_5_1.html [ RetryOnFailure ]

# This crashes in Android WebView on the Nexus 6, preventing the
# suite from running further. Rather than add multiple
# suppressions, skip it until it's passing at least in content
# shell.
crbug.com/499555 [ android android-nexus-6 no-passthrough ] conformance/extensions/oes-texture-float-with-video.html [ Skip ]
crbug.com/499555 [ android android-nexus-6 ] conformance/extensions/oes-texture-float-with-video.html [ Skip ]

# The test that runs after conformance/state/gl-object-get-calls.html is failing
# on Nexus 5/6 consistently and other Android bots (eg. Nexus 5X) sometimes.
Expand All @@ -600,7 +591,7 @@ crbug.com/478572 [ android android-nexus-5 ] deqp/data/gles2/shaders/linkage.htm
crbug.com/678850 [ android android-nexus-5 ] conformance/more/functions/vertexAttribPointerBadArgs.html [ Failure ]
crbug.com/678850 [ android android-nexus-5 ] conformance/attribs/gl-vertexattribpointer.html [ Failure ]

crbug.com/891456 [ android android-nexus-5 no-passthrough ] conformance/extensions/oes-texture-float-with-video.html [ RetryOnFailure ]
crbug.com/891456 [ android android-nexus-5 ] conformance/extensions/oes-texture-float-with-video.html [ RetryOnFailure ]

# Nexus 5X
# Was timing out randomly on android_optional_gpu_tests_rel, but became so
Expand All @@ -623,7 +614,7 @@ crbug.com/1056830 [ android android-nexus-5x ] conformance/extensions/webgl-comp
# Timing out on this device for unknown reasons.
crbug.com/1099148 [ android android-nexus-5x ] deqp/data/gles2/shaders/swizzles.html [ Skip ]
crbug.com/1122644 [ android android-nexus-5x ] conformance/textures/misc/texture-upload-size.html [ Skip ]
crbug.com/1163306 [ android android-nexus-5x no-passthrough ] conformance/textures/image_bitmap_from_video/* [ RetryOnFailure ]
crbug.com/1163306 [ android android-nexus-5x ] conformance/textures/image_bitmap_from_video/* [ RetryOnFailure ]

# Nexus 6 (Adreno 420)
crbug.com/499555 [ android android-nexus-6 ] conformance/context/context-attributes-alpha-depth-stencil-antialias.html [ Failure ]
Expand Down Expand Up @@ -666,7 +657,7 @@ crbug.com/606096 [ android android-nexus-9 ] conformance/glsl/bugs/multiplicatio
crbug.com/891456 [ android android-nexus-9 ] conformance/extensions/oes-texture-half-float-with-video.html [ Failure ]
crbug.com/1025790 [ android android-nexus-9 ] conformance/textures/misc/tex-image-canvas-corruption.html [ Skip ]
crbug.com/478572 [ android android-nexus-9 ] deqp/data/gles2/shaders/functions.html [ Failure ]
crbug.com/891456 [ android android-shield-android-tv no-passthrough ] conformance/extensions/oes-texture-float-with-video.html [ Failure ]
crbug.com/891456 [ android android-shield-android-tv ] conformance/extensions/oes-texture-float-with-video.html [ Failure ]
crbug.com/891456 [ android android-shield-android-tv ] conformance/extensions/oes-texture-half-float-with-video.html [ Failure ]
crbug.com/891456 [ android android-shield-android-tv ] conformance/textures/image_bitmap_from_video/tex-2d-luminance_alpha-luminance_alpha-unsigned_byte.html [ RetryOnFailure ]
crbug.com/1025790 [ android android-shield-android-tv ] conformance/textures/misc/tex-image-canvas-corruption.html [ Skip ]
Expand All @@ -690,8 +681,8 @@ crbug.com/1178518 [ android android-nexus-6 android-chromium ] conformance/textu
crbug.com/1175223 [ android android-pixel-4 angle-opengles passthrough ] conformance/extensions/angle-instanced-arrays-out-of-bounds.html [ Failure ]
crbug.com/1175226 [ android android-pixel-4 no-passthrough no-swiftshader-gl ] conformance/rendering/blending.html [ Failure ]
crbug.com/1179432 [ android android-pixel-4 no-passthrough ] conformance/rendering/polygon-offset.html [ RetryOnFailure ]
crbug.com/1191030 [ android android-pixel-4 no-passthrough ] conformance/textures/misc/video-rotation.html [ Failure ]
crbug.com/1187332 [ android android-pixel-4 no-passthrough ] conformance/textures/misc/texture-corner-case-videos.html [ RetryOnFailure ]
crbug.com/1191030 [ android android-pixel-4 ] conformance/textures/misc/video-rotation.html [ Failure ]
crbug.com/1187332 [ android android-pixel-4 ] conformance/textures/misc/texture-corner-case-videos.html [ RetryOnFailure ]

# Misc failures
crbug.com/angleproject/2988 [ android angle-opengles ] conformance/context/context-size-change.html [ Failure ]
Expand Down

0 comments on commit 76d5183

Please sign in to comment.