[IOS] Create feature flag for Tabs Search

Bug: 1263582 Change-Id: Iec87b1825cc69a5b603c4d4903410c29d6f0d9cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3244317 Auto-Submit: Mohammad Refaat <mrefaat@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/main@{#935419}
FairyWorld · Oct 27, 2021 · 76b14f5 · 76b14f5
1 parent 04fd5c5
commit 76b14f5
Show file tree

Hide file tree

Showing 6 changed files with 30 additions and 0 deletions.
diff --git a/chrome/browser/flag-metadata.json b/chrome/browser/flag-metadata.json
@@ -5193,6 +5193,11 @@
     "owners": [ "mrefaat", "michaeldo", "bling-flags@google.com" ],
     "expiry_milestone": 98
   },
+  {
+    "name": "tabs-search-ios",
+    "owners": [ "mrefaat", "michaeldo", "bling-flags@google.com" ],
+    "expiry_milestone":100
+  },
   {
     "name": "terminal-ssh",
     "owners": [ "lxj@google.com", "joelhockey", "//chrome/browser/ash/guest_os/OWNERS" ],

diff --git a/ios/chrome/browser/flags/about_flags.mm b/ios/chrome/browser/flags/about_flags.mm
@@ -643,6 +643,9 @@
     {"tabs-bulkactions-ios", flag_descriptions::kTabsBulkActionsName,
      flag_descriptions::kTabsBulkActionsDescription, flags_ui::kOsIos,
      FEATURE_VALUE_TYPE(kTabsBulkActions)},
+    {"tabs-search-ios", flag_descriptions::kTabsSearchName,
+     flag_descriptions::kTabsSearchDescription, flags_ui::kOsIos,
+     FEATURE_VALUE_TYPE(kTabsSearch)},
     {"incognito-brand-consistency-for-ios",
      flag_descriptions::kIncognitoBrandConsistencyForIOSName,
      flag_descriptions::kIncognitoBrandConsistencyForIOSDescription,

diff --git a/ios/chrome/browser/flags/ios_chrome_flag_descriptions.cc b/ios/chrome/browser/flags/ios_chrome_flag_descriptions.cc
@@ -494,6 +494,11 @@ const char kTabsBulkActionsDescription[] =
     "Enables the selection mode in the Tab grid where users can perform "
     "actions on multiple tabs at once for iOS 13 and above.";
 
+extern const char kTabsSearchName[] = "Enable Tabs Search";
+extern const char kTabsSearchDescription[] =
+    "Enables the search mode in the Tab grid where users can search open tabs "
+    "or recent tabs.";
+
 const char kToolbarContainerName[] = "Use Toolbar Containers";
 const char kToolbarContainerDescription[] =
     "When enabled, the toolbars and their fullscreen animations will be "

diff --git a/ios/chrome/browser/flags/ios_chrome_flag_descriptions.h b/ios/chrome/browser/flags/ios_chrome_flag_descriptions.h
@@ -438,6 +438,10 @@ extern const char kSyncTrustedVaultPassphraseRecoveryDescription[];
 extern const char kTabsBulkActionsName[];
 extern const char kTabsBulkActionsDescription[];
 
+// Title and description for the flag to enable tabs search feature.
+extern const char kTabsSearchName[];
+extern const char kTabsSearchDescription[];
+
 // Title and description for the flag to enable the toolbar container
 // implementation.
 extern const char kToolbarContainerName[];

diff --git a/ios/chrome/browser/ui/tab_switcher/tab_grid/features.h b/ios/chrome/browser/ui/tab_switcher/tab_grid/features.h
@@ -10,7 +10,13 @@
 // Feature flag to enable Bulk Actions.
 extern const base::Feature kTabsBulkActions;
 
+// Feature flag to enable Tabs Search.
+extern const base::Feature kTabsSearch;
+
 // Whether the kTabsBulkActions flag is enabled.
 bool IsTabsBulkActionsEnabled();
 
+// Whether the kTabsSearch flag is enabled.
+bool IsTabsSearchEnabled();
+
 #endif  // IOS_CHROME_BROWSER_UI_TAB_SWITCHER_TAB_GRID_FEATURES_H_
diff --git a/ios/chrome/browser/ui/tab_switcher/tab_grid/features.mm b/ios/chrome/browser/ui/tab_switcher/tab_grid/features.mm
@@ -11,6 +11,13 @@
 const base::Feature kTabsBulkActions{"TabsBulkActions",
                                      base::FEATURE_DISABLED_BY_DEFAULT};
 
+const base::Feature kTabsSearch{"TabsSearch",
+                                base::FEATURE_DISABLED_BY_DEFAULT};
+
 bool IsTabsBulkActionsEnabled() {
   return base::FeatureList::IsEnabled(kTabsBulkActions);
 }
+
+bool IsTabsSearchEnabled() {
+  return base::FeatureList::IsEnabled(kTabsSearch);
+}