Skip to content

Commit

Permalink
Fix glGetUniform*vRobustANGLE entry points using the wrong units for …
Browse files Browse the repository at this point in the history
…bufSize.

BUG=602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2502403002
Cr-Commit-Position: refs/heads/master@{#432577}
  • Loading branch information
vonture authored and Commit bot committed Nov 16, 2016
1 parent b3c467a commit 66521ad
Showing 1 changed file with 9 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1147,8 +1147,10 @@ error::Error GLES2DecoderPassthroughImpl::DoGetUniformfv(GLuint program,
GLsizei bufsize,
GLsizei* length,
GLfloat* params) {
// GetUniform*RobustANGLE entry points expect bufsize in bytes like the entry
// points in GL_EXT_robustness
glGetUniformfvRobustANGLE(GetProgramServiceID(program, resources_), location,
bufsize, length, params);
bufsize * sizeof(*params), length, params);
return error::kNoError;
}

Expand All @@ -1157,8 +1159,10 @@ error::Error GLES2DecoderPassthroughImpl::DoGetUniformiv(GLuint program,
GLsizei bufsize,
GLsizei* length,
GLint* params) {
// GetUniform*RobustANGLE entry points expect bufsize in bytes like the entry
// points in GL_EXT_robustness
glGetUniformivRobustANGLE(GetProgramServiceID(program, resources_), location,
bufsize, length, params);
bufsize * sizeof(*params), length, params);
return error::kNoError;
}

Expand All @@ -1167,8 +1171,10 @@ error::Error GLES2DecoderPassthroughImpl::DoGetUniformuiv(GLuint program,
GLsizei bufsize,
GLsizei* length,
GLuint* params) {
// GetUniform*RobustANGLE entry points expect bufsize in bytes like the entry
// points in GL_EXT_robustness
glGetUniformuivRobustANGLE(GetProgramServiceID(program, resources_), location,
bufsize, length, params);
bufsize * sizeof(*params), length, params);
return error::kNoError;
}

Expand Down

0 comments on commit 66521ad

Please sign in to comment.