Skip to content

Commit

Permalink
WPT: Update display-override-member tests to make them all promotable
Browse files Browse the repository at this point in the history
This CL updates all wpt/appmanifest/display-override-member tests.
Now they can be installed.

Bug: 1247435
Change-Id: I1ada34bf0fbb62ded348cbbb8ac60708b9e3d15d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3173581
Auto-Submit: Fangzhen Song <songfangzhen@bytedance.com>
Reviewed-by: Phillis Tang <phillis@chromium.org>
Commit-Queue: Fangzhen Song <songfangzhen@bytedance.com>
Cr-Commit-Position: refs/heads/main@{#924617}
  • Loading branch information
song-fangzhen authored and Chromium LUCI CQ committed Sep 24, 2021
1 parent 8bf5894 commit 563f01e
Show file tree
Hide file tree
Showing 23 changed files with 126 additions and 21 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
<title>Test "browser" in display-override member + media feature</title>
<link rel="help" href="https://w3c.github.io/manifest/#dom-displaymodetype-browser" />
<link rel="help" href="https://w3c.github.io/manifest/#the-display-mode-media-feature" />
<link rel="manifest" href="display-override-member-media-feature-browser.webmanifest" />
<link rel="manifest" href="resources/display-override-member-media-feature-browser.webmanifest" />
<script src="resources/display-override-member-media-feature-manual.js"></script>
<meta name="viewport" content="width=device-width, initial-scale=1">
<h1>Test "browser" in display-override member + media feature</h1>
<style>
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
<title>Test "fullscreen" in display-override member + media feature</title>
<link rel="help" href="https://w3c.github.io/manifest/#dom-displaymodetype-fullscreen" />
<link rel="help" href="https://w3c.github.io/manifest/#the-display-mode-media-feature" />
<link rel="manifest" href="display-override-member-media-feature-fullscreen.webmanifest" />
<link rel="manifest" href="resources/display-override-member-media-feature-fullscreen.webmanifest" />
<script src="resources/display-override-member-media-feature-manual.js"></script>
<meta name="viewport" content="width=device-width, initial-scale=1">
<h1>Test "fullscreen" in display-override member + media feature</h1>
<style>
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
<title>Test "minimal-ui" in display-override member + media feature</title>
<link rel="help" href="https://w3c.github.io/manifest/#dom-displaymodetype-minimal-ui" />
<link rel="help" href="https://w3c.github.io/manifest/#the-display-mode-media-feature" />
<link rel="manifest" href="display-override-member-media-feature-minimal-ui.webmanifest" />
<link rel="manifest" href="resources/display-override-member-media-feature-minimal-ui.webmanifest" />
<script src="resources/display-override-member-media-feature-manual.js"></script>
<meta name="viewport" content="width=device-width, initial-scale=1">
<h1>Test "minimal-ui" in display-override member + media feature</h1>
<style>
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
// Some user agents only offer app installation if there is a SW and it handles
// offline requests.

const cacheVersion = "1.2";
const CACHE_NAME = `cache-v${cacheVersion}`;

// The resources cached by this service worker.
const resources = [
"display-override-member-media-feature-browser-manual.tentative.html",
"display-override-member-media-feature-fullscreen-manual.tentative.html",
"display-override-member-media-feature-minimal-ui-manual.tentative.html",
"display-override-member-media-feature-standalone-manual.tentative.html",
"display-override-member-media-feature-standalone-overrides-browser-manual.tentative.html",
"display-override-member-media-feature-service-worker.js",
"resources/display-override-member-media-feature-manual.js",
"resources/icon.png",
];

// Load all resources for this service worker.
const precache = async () => {
const cache = await caches.open(CACHE_NAME);
await cache.addAll(resources);
};

// Get a resource from the cache.
const fromCache = async request => {
const cache = await caches.open(CACHE_NAME);
return await cache.match(request.url);
};

// Attempt to get resources from the network first, fallback to the cache if we're
// offline.
const networkFallbackToCache = async request => {
try {
const response = await fetch(request);
if (response.ok) return response;
} catch (err) {}
return await fromCache(request);
};

// When we have a new service worker, update the caches and swap immediately.
self.addEventListener("install", e => {
e.waitUntil(precache().then(() => self.skipWaiting()));
});

// Claim existing clients.
self.addEventListener("activate", e => {
e.waitUntil(self.clients.claim());
});

// When a resource need to be fetched, check whether it is
// contained in the cache and return the cached version, otherwise
// get it from the network.
self.addEventListener("fetch", e => {
e.respondWith(networkFallbackToCache(e.request));
});
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
<title>Test "standalone" in display-override member + media feature</title>
<link rel="help" href="https://w3c.github.io/manifest/#the-display-mode-media-feature" />
<link rel="help" href="https://w3c.github.io/manifest/#dom-displaymodetype-standalone" />
<link rel="manifest" href="display-override-member-media-feature-standalone.webmanifest" />
<link rel="manifest" href="resources/display-override-member-media-feature-standalone.webmanifest" />
<script src="resources/display-override-member-media-feature-manual.js"></script>
<meta name="viewport" content="width=device-width, initial-scale=1">
<h1>Test "standalone" in display-override member + media feature</h1>
<style>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
<link rel="help" href="https://w3c.github.io/manifest/#the-display-mode-media-feature" />
<link rel="help" href="https://w3c.github.io/manifest/#dom-displaymodetype-browser" />
<link rel="help" href="https://w3c.github.io/manifest/#dom-displaymodetype-standalone" />
<link rel="manifest" href="display-override-member-media-feature-standalone-overrides-browser.webmanifest" />
<link rel="manifest" href="resources/display-override-member-media-feature-standalone-overrides-browser.webmanifest" />
<script src="resources/display-override-member-media-feature-manual.js"></script>
<meta name="viewport" content="width=device-width, initial-scale=1">
<h1>Test "standalone" in display-override member + "browser" in display member + media feature</h1>
<style>
Expand Down

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"name": "Display override member media feature WPT",
"icons": [
{
"src": "icon.png",
"sizes": "192x192"
}
],
"start_url": "../display-override-member-media-feature-browser-manual.tentative.html",
"display_override": [ "browser" ]
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"name": "Display override member media feature WPT",
"icons": [
{
"src": "icon.png",
"sizes": "192x192"
}
],
"start_url": "../display-override-member-media-feature-fullscreen-manual.tentative.html",
"display_override": [ "fullscreen" ]
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
if ('serviceWorker' in navigator) {
navigator.serviceWorker.register(
'display-override-member-media-feature-service-worker.js');
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"name": "Display override member media feature WPT",
"icons": [
{
"src": "icon.png",
"sizes": "192x192"
}
],
"start_url": "../display-override-member-media-feature-browser-manual.tentative.html",
"display_override": [ "minimal-ui" ]
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"name": "Display override member media feature WPT",
"icons": [
{
"src": "icon.png",
"sizes": "192x192"
}
],
"start_url": "../display-override-member-media-feature-browser-manual.tentative.html",
"display": "browser",
"display_override": [ "standalone" ]
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"name": "Display override member media feature WPT",
"icons": [
{
"src": "icon.png",
"sizes": "192x192"
}
],
"start_url": "../display-override-member-media-feature-browser-manual.tentative.html",
"display_override": [ "standalone" ]
}
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 563f01e

Please sign in to comment.