Run clang-tidy modernize-use-equals-{delete,default} on //device

See the bugs and cxx post for justification and details: https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8 This change was done using clang-tidy as described here: https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md In some cases the the tool leaves behind a string of commas where it replaced a member initializer list (https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with: git diff --name-only | \ xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/' BUG=778959,778957 Change-Id: I62ef8d753b19c4e3e5010ccccfd682cbdb44eb24 Reviewed-on: https://chromium-review.googlesource.com/789722 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Chris Watkins <watk@chromium.org> Cr-Commit-Position: refs/heads/master@{#520463}
FairyWorld · Nov 30, 2017 · 52eb868 · 52eb868
1 parent 00911dd
commit 52eb868
Show file tree

Hide file tree

Showing 156 changed files with 300 additions and 312 deletions.
diff --git a/device/base/mock_device_client.cc b/device/base/mock_device_client.cc
@@ -8,9 +8,9 @@
 
 namespace device {
 
-MockDeviceClient::MockDeviceClient() {}
+MockDeviceClient::MockDeviceClient() = default;
 
-MockDeviceClient::~MockDeviceClient() {}
+MockDeviceClient::~MockDeviceClient() = default;
 
 UsbService* MockDeviceClient::GetUsbService() {
   return usb_service();

diff --git a/device/base/synchronization/one_writer_seqlock_unittest.cc b/device/base/synchronization/one_writer_seqlock_unittest.cc
@@ -23,7 +23,7 @@ struct TestData {
 
 class BasicSeqLockTestThread : public base::PlatformThread::Delegate {
  public:
-  BasicSeqLockTestThread() {}
+  BasicSeqLockTestThread() = default;
 
   void Init(OneWriterSeqLock* seqlock,
             TestData* data,

diff --git a/device/bluetooth/adapter_factory.cc b/device/bluetooth/adapter_factory.cc
@@ -13,7 +13,7 @@
 namespace bluetooth {
 
 AdapterFactory::AdapterFactory() : weak_ptr_factory_(this) {}
-AdapterFactory::~AdapterFactory() {}
+AdapterFactory::~AdapterFactory() = default;
 
 // static
 void AdapterFactory::Create(mojom::AdapterFactoryRequest request) {

diff --git a/device/bluetooth/bluetooth_adapter.cc b/device/bluetooth/bluetooth_adapter.cc
@@ -20,10 +20,8 @@
 
 namespace device {
 
-BluetoothAdapter::ServiceOptions::ServiceOptions() {
-}
-BluetoothAdapter::ServiceOptions::~ServiceOptions() {
-}
+BluetoothAdapter::ServiceOptions::ServiceOptions() = default;
+BluetoothAdapter::ServiceOptions::~ServiceOptions() = default;
 
 #if !defined(OS_ANDROID) && !defined(OS_CHROMEOS) && !defined(OS_MACOSX) && \
     !defined(OS_WIN) && !defined(OS_LINUX)
@@ -287,8 +285,7 @@ void BluetoothAdapter::NotifyGattDescriptorValueChanged(
 BluetoothAdapter::BluetoothAdapter() : weak_ptr_factory_(this) {
 }
 
-BluetoothAdapter::~BluetoothAdapter() {
-}
+BluetoothAdapter::~BluetoothAdapter() = default;
 
 void BluetoothAdapter::OnStartDiscoverySession(
     std::unique_ptr<BluetoothDiscoveryFilter> discovery_filter,

diff --git a/device/bluetooth/bluetooth_adapter_factory.cc b/device/bluetooth/bluetooth_adapter_factory.cc
@@ -63,7 +63,7 @@ void RunAdapterCallbacks() {
 
 }  // namespace
 
-BluetoothAdapterFactory::~BluetoothAdapterFactory() {}
+BluetoothAdapterFactory::~BluetoothAdapterFactory() = default;
 
 // static
 BluetoothAdapterFactory& BluetoothAdapterFactory::Get() {
@@ -154,7 +154,8 @@ bool BluetoothAdapterFactory::HasSharedInstanceForTesting() {
 BluetoothAdapterFactory::GlobalValuesForTesting::GlobalValuesForTesting()
     : weak_ptr_factory_(this) {}
 
-BluetoothAdapterFactory::GlobalValuesForTesting::~GlobalValuesForTesting() {}
+BluetoothAdapterFactory::GlobalValuesForTesting::~GlobalValuesForTesting() =
+    default;
 
 base::WeakPtr<BluetoothAdapterFactory::GlobalValuesForTesting>
 BluetoothAdapterFactory::GlobalValuesForTesting::GetWeakPtr() {
@@ -168,6 +169,6 @@ BluetoothAdapterFactory::InitGlobalValuesForTesting() {
   return v;
 }
 
-BluetoothAdapterFactory::BluetoothAdapterFactory() {}
+BluetoothAdapterFactory::BluetoothAdapterFactory() = default;
 
 }  // namespace device
diff --git a/device/bluetooth/bluetooth_adapter_unittest.cc b/device/bluetooth/bluetooth_adapter_unittest.cc
@@ -42,8 +42,7 @@ namespace device {
 
 class TestBluetoothAdapter : public BluetoothAdapter {
  public:
-  TestBluetoothAdapter() {
-  }
+  TestBluetoothAdapter() = default;
 
   std::string GetAddress() const override { return ""; }
 
@@ -138,7 +137,7 @@ class TestBluetoothAdapter : public BluetoothAdapter {
   }
 
  protected:
-  ~TestBluetoothAdapter() override {}
+  ~TestBluetoothAdapter() override = default;
 
   void AddDiscoverySession(
       BluetoothDiscoveryFilter* discovery_filter,

diff --git a/device/bluetooth/bluetooth_advertisement.cc b/device/bluetooth/bluetooth_advertisement.cc
@@ -10,8 +10,7 @@ BluetoothAdvertisement::Data::Data(AdvertisementType type)
     : type_(type), include_tx_power_(false) {
 }
 
-BluetoothAdvertisement::Data::~Data() {
-}
+BluetoothAdvertisement::Data::~Data() = default;
 
 BluetoothAdvertisement::Data::Data()
     : type_(ADVERTISEMENT_TYPE_BROADCAST), include_tx_power_(false) {
@@ -29,9 +28,7 @@ void BluetoothAdvertisement::RemoveObserver(
   observers_.RemoveObserver(observer);
 }
 
-BluetoothAdvertisement::BluetoothAdvertisement() {
-}
-BluetoothAdvertisement::~BluetoothAdvertisement() {
-}
+BluetoothAdvertisement::BluetoothAdvertisement() = default;
+BluetoothAdvertisement::~BluetoothAdvertisement() = default;
 
 }  // namespace device
diff --git a/device/bluetooth/bluetooth_device.cc b/device/bluetooth/bluetooth_device.cc
@@ -93,7 +93,7 @@ BluetoothDevice::ConnectionInfo::ConnectionInfo(
       transmit_power(transmit_power),
       max_transmit_power(max_transmit_power) {}
 
-BluetoothDevice::ConnectionInfo::~ConnectionInfo() {}
+BluetoothDevice::ConnectionInfo::~ConnectionInfo() = default;
 
 base::string16 BluetoothDevice::GetNameForDisplay() const {
   base::Optional<std::string> name = GetName();

diff --git a/device/bluetooth/bluetooth_discovery_filter.cc b/device/bluetooth/bluetooth_discovery_filter.cc
@@ -17,8 +17,7 @@ BluetoothDiscoveryFilter::BluetoothDiscoveryFilter(
   SetTransport(transport);
 }
 
-BluetoothDiscoveryFilter::~BluetoothDiscoveryFilter() {
-}
+BluetoothDiscoveryFilter::~BluetoothDiscoveryFilter() = default;
 
 bool BluetoothDiscoveryFilter::GetRSSI(int16_t* out_rssi) const {
   DCHECK(out_rssi);

diff --git a/device/bluetooth/bluetooth_gatt_characteristic.cc b/device/bluetooth/bluetooth_gatt_characteristic.cc
@@ -6,8 +6,8 @@
 
 namespace device {
 
-BluetoothGattCharacteristic::BluetoothGattCharacteristic() {}
+BluetoothGattCharacteristic::BluetoothGattCharacteristic() = default;
 
-BluetoothGattCharacteristic::~BluetoothGattCharacteristic() {}
+BluetoothGattCharacteristic::~BluetoothGattCharacteristic() = default;
 
 }  // namespace device
diff --git a/device/bluetooth/bluetooth_gatt_descriptor.cc b/device/bluetooth/bluetooth_gatt_descriptor.cc
@@ -71,10 +71,8 @@ BluetoothGattDescriptor::CharacteristicAggregateFormatUuid() {
   return g_uuids.Get().uuids_[5];
 }
 
-BluetoothGattDescriptor::BluetoothGattDescriptor() {
-}
+BluetoothGattDescriptor::BluetoothGattDescriptor() = default;
 
-BluetoothGattDescriptor::~BluetoothGattDescriptor() {
-}
+BluetoothGattDescriptor::~BluetoothGattDescriptor() = default;
 
 }  // namespace device
diff --git a/device/bluetooth/bluetooth_gatt_service.cc b/device/bluetooth/bluetooth_gatt_service.cc
@@ -6,10 +6,8 @@
 
 namespace device {
 
-BluetoothGattService::BluetoothGattService() {
-}
+BluetoothGattService::BluetoothGattService() = default;
 
-BluetoothGattService::~BluetoothGattService() {
-}
+BluetoothGattService::~BluetoothGattService() = default;
 
 }  // namespace device
diff --git a/device/bluetooth/bluetooth_local_gatt_characteristic.cc b/device/bluetooth/bluetooth_local_gatt_characteristic.cc
@@ -22,8 +22,8 @@ BluetoothLocalGattCharacteristic::Create(const BluetoothUUID& uuid,
 }
 #endif
 
-BluetoothLocalGattCharacteristic::BluetoothLocalGattCharacteristic() {}
+BluetoothLocalGattCharacteristic::BluetoothLocalGattCharacteristic() = default;
 
-BluetoothLocalGattCharacteristic::~BluetoothLocalGattCharacteristic() {}
+BluetoothLocalGattCharacteristic::~BluetoothLocalGattCharacteristic() = default;
 
 }  // namespace device
diff --git a/device/bluetooth/bluetooth_local_gatt_descriptor.cc b/device/bluetooth/bluetooth_local_gatt_descriptor.cc
@@ -21,8 +21,8 @@ BluetoothLocalGattDescriptor::Create(
 }
 #endif
 
-BluetoothLocalGattDescriptor::BluetoothLocalGattDescriptor() {}
+BluetoothLocalGattDescriptor::BluetoothLocalGattDescriptor() = default;
 
-BluetoothLocalGattDescriptor::~BluetoothLocalGattDescriptor() {}
+BluetoothLocalGattDescriptor::~BluetoothLocalGattDescriptor() = default;
 
 }  // namespace device
diff --git a/device/bluetooth/bluetooth_local_gatt_service.cc b/device/bluetooth/bluetooth_local_gatt_service.cc
@@ -21,8 +21,8 @@ base::WeakPtr<BluetoothLocalGattService> BluetoothLocalGattService::Create(
 }
 #endif
 
-BluetoothLocalGattService::BluetoothLocalGattService() {}
+BluetoothLocalGattService::BluetoothLocalGattService() = default;
 
-BluetoothLocalGattService::~BluetoothLocalGattService() {}
+BluetoothLocalGattService::~BluetoothLocalGattService() = default;
 
 }  // namespace device
diff --git a/device/bluetooth/bluetooth_remote_gatt_characteristic.cc b/device/bluetooth/bluetooth_remote_gatt_characteristic.cc
@@ -49,7 +49,7 @@ BluetoothRemoteGattCharacteristic::NotifySessionCommand::NotifySessionCommand(
     : execute_callback_(execute_callback), cancel_callback_(cancel_callback) {}
 
 BluetoothRemoteGattCharacteristic::NotifySessionCommand::
-    ~NotifySessionCommand() {}
+    ~NotifySessionCommand() = default;
 
 void BluetoothRemoteGattCharacteristic::NotifySessionCommand::Execute() {
   execute_callback_.Run(COMMAND_NONE, RESULT_SUCCESS,

diff --git a/device/bluetooth/bluetooth_remote_gatt_descriptor.cc b/device/bluetooth/bluetooth_remote_gatt_descriptor.cc
@@ -14,8 +14,8 @@
 
 namespace device {
 
-BluetoothRemoteGattDescriptor::BluetoothRemoteGattDescriptor() {}
+BluetoothRemoteGattDescriptor::BluetoothRemoteGattDescriptor() = default;
 
-BluetoothRemoteGattDescriptor::~BluetoothRemoteGattDescriptor() {}
+BluetoothRemoteGattDescriptor::~BluetoothRemoteGattDescriptor() = default;
 
 }  // namespace device
diff --git a/device/bluetooth/bluetooth_remote_gatt_service.cc b/device/bluetooth/bluetooth_remote_gatt_service.cc
@@ -9,9 +9,9 @@
 
 namespace device {
 
-BluetoothRemoteGattService::BluetoothRemoteGattService() {}
+BluetoothRemoteGattService::BluetoothRemoteGattService() = default;
 
-BluetoothRemoteGattService::~BluetoothRemoteGattService() {}
+BluetoothRemoteGattService::~BluetoothRemoteGattService() = default;
 
 std::vector<BluetoothRemoteGattCharacteristic*>
 BluetoothRemoteGattService::GetCharacteristicsByUUID(

diff --git a/device/bluetooth/bluetooth_socket.cc b/device/bluetooth/bluetooth_socket.cc
@@ -6,6 +6,6 @@
 
 namespace device {
 
-BluetoothSocket::~BluetoothSocket() {}
+BluetoothSocket::~BluetoothSocket() = default;
 
 }  // namespace device
diff --git a/device/bluetooth/bluetooth_socket_net.cc b/device/bluetooth/bluetooth_socket_net.cc
@@ -37,7 +37,7 @@ namespace device {
 BluetoothSocketNet::WriteRequest::WriteRequest()
     : buffer_size(0) {}
 
-BluetoothSocketNet::WriteRequest::~WriteRequest() {}
+BluetoothSocketNet::WriteRequest::~WriteRequest() = default;
 
 BluetoothSocketNet::BluetoothSocketNet(
     scoped_refptr<base::SequencedTaskRunner> ui_task_runner,

diff --git a/device/bluetooth/bluetooth_uuid.cc b/device/bluetooth/bluetooth_uuid.cc
@@ -72,8 +72,7 @@ BluetoothUUID::BluetoothUUID(const std::string& uuid) {
 BluetoothUUID::BluetoothUUID() : format_(kFormatInvalid) {
 }
 
-BluetoothUUID::~BluetoothUUID() {
-}
+BluetoothUUID::~BluetoothUUID() = default;
 
 bool BluetoothUUID::IsValid() const {
   return format_ != kFormatInvalid;

diff --git a/device/bluetooth/bluez/bluetooth_adapter_profile_bluez.cc b/device/bluetooth/bluez/bluetooth_adapter_profile_bluez.cc
@@ -52,7 +52,7 @@ BluetoothAdapterProfileBlueZ::BluetoothAdapterProfileBlueZ(
   DCHECK(profile_.get());
 }
 
-BluetoothAdapterProfileBlueZ::~BluetoothAdapterProfileBlueZ() {}
+BluetoothAdapterProfileBlueZ::~BluetoothAdapterProfileBlueZ() = default;
 
 bool BluetoothAdapterProfileBlueZ::SetDelegate(
     const dbus::ObjectPath& device_path,

diff --git a/device/bluetooth/bluez/bluetooth_bluez_unittest.cc b/device/bluetooth/bluez/bluetooth_bluez_unittest.cc
@@ -68,7 +68,7 @@ int GetDeviceIndexByAddress(const BluetoothAdapter::DeviceList& devices,
 class FakeBluetoothProfileServiceProviderDelegate
     : public bluez::BluetoothProfileServiceProvider::Delegate {
  public:
-  FakeBluetoothProfileServiceProviderDelegate() {}
+  FakeBluetoothProfileServiceProviderDelegate() = default;
 
   // bluez::BluetoothProfileServiceProvider::Delegate:
   void Released() override {}
@@ -100,7 +100,7 @@ class TestPairingDelegate : public BluetoothDevice::PairingDelegate {
         authorize_pairing_count_(0),
         last_passkey_(9999999U),
         last_entered_(999U) {}
-  ~TestPairingDelegate() override {}
+  ~TestPairingDelegate() override = default;
 
   void RequestPinCode(BluetoothDevice* device) override {
     ++call_count_;

diff --git a/device/bluetooth/bluez/bluetooth_gatt_characteristic_bluez.cc b/device/bluetooth/bluez/bluetooth_gatt_characteristic_bluez.cc
@@ -13,7 +13,7 @@ BluetoothGattCharacteristicBlueZ::BluetoothGattCharacteristicBlueZ(
     dbus::ObjectPath object_path)
     : object_path_(object_path), weak_ptr_factory_(this) {}
 
-BluetoothGattCharacteristicBlueZ::~BluetoothGattCharacteristicBlueZ() {}
+BluetoothGattCharacteristicBlueZ::~BluetoothGattCharacteristicBlueZ() = default;
 
 std::string BluetoothGattCharacteristicBlueZ::GetIdentifier() const {
   return object_path_.value();

diff --git a/device/bluetooth/bluez/bluetooth_gatt_descriptor_bluez.cc b/device/bluetooth/bluez/bluetooth_gatt_descriptor_bluez.cc
@@ -12,7 +12,7 @@ BluetoothGattDescriptorBlueZ::BluetoothGattDescriptorBlueZ(
     const dbus::ObjectPath& object_path)
     : object_path_(object_path) {}
 
-BluetoothGattDescriptorBlueZ::~BluetoothGattDescriptorBlueZ() {}
+BluetoothGattDescriptorBlueZ::~BluetoothGattDescriptorBlueZ() = default;
 
 std::string BluetoothGattDescriptorBlueZ::GetIdentifier() const {
   return object_path_.value();

diff --git a/device/bluetooth/bluez/bluetooth_gatt_service_bluez.cc b/device/bluetooth/bluez/bluetooth_gatt_service_bluez.cc
@@ -18,7 +18,7 @@ BluetoothGattServiceBlueZ::BluetoothGattServiceBlueZ(
   DCHECK(adapter_);
 }
 
-BluetoothGattServiceBlueZ::~BluetoothGattServiceBlueZ() {}
+BluetoothGattServiceBlueZ::~BluetoothGattServiceBlueZ() = default;
 
 std::string BluetoothGattServiceBlueZ::GetIdentifier() const {
   return object_path_.value();

diff --git a/device/bluetooth/bluez/bluetooth_local_gatt_characteristic_bluez.cc b/device/bluetooth/bluez/bluetooth_local_gatt_characteristic_bluez.cc
@@ -54,7 +54,7 @@ BluetoothLocalGattCharacteristicBlueZ::BluetoothLocalGattCharacteristicBlueZ(
 }
 
 BluetoothLocalGattCharacteristicBlueZ::
-    ~BluetoothLocalGattCharacteristicBlueZ() {}
+    ~BluetoothLocalGattCharacteristicBlueZ() = default;
 
 device::BluetoothUUID BluetoothLocalGattCharacteristicBlueZ::GetUUID() const {
   return uuid_;

diff --git a/device/bluetooth/bluez/bluetooth_local_gatt_descriptor_bluez.cc b/device/bluetooth/bluez/bluetooth_local_gatt_descriptor_bluez.cc
@@ -50,7 +50,8 @@ BluetoothLocalGattDescriptorBlueZ::BluetoothLocalGattDescriptorBlueZ(
   characteristic->AddDescriptor(base::WrapUnique(this));
 }
 
-BluetoothLocalGattDescriptorBlueZ::~BluetoothLocalGattDescriptorBlueZ() {}
+BluetoothLocalGattDescriptorBlueZ::~BluetoothLocalGattDescriptorBlueZ() =
+    default;
 
 device::BluetoothUUID BluetoothLocalGattDescriptorBlueZ::GetUUID() const {
   return uuid_;

diff --git a/device/bluetooth/bluez/bluetooth_local_gatt_service_bluez.cc b/device/bluetooth/bluez/bluetooth_local_gatt_service_bluez.cc
@@ -49,7 +49,7 @@ BluetoothLocalGattServiceBlueZ::BluetoothLocalGattServiceBlueZ(
   adapter->AddLocalGattService(base::WrapUnique(this));
 }
 
-BluetoothLocalGattServiceBlueZ::~BluetoothLocalGattServiceBlueZ() {}
+BluetoothLocalGattServiceBlueZ::~BluetoothLocalGattServiceBlueZ() = default;
 
 device::BluetoothUUID BluetoothLocalGattServiceBlueZ::GetUUID() const {
   return uuid_;

diff --git a/device/bluetooth/bluez/bluetooth_remote_gatt_descriptor_bluez.cc b/device/bluetooth/bluez/bluetooth_remote_gatt_descriptor_bluez.cc
@@ -46,7 +46,8 @@ BluetoothRemoteGattDescriptorBlueZ::BluetoothRemoteGattDescriptorBlueZ(
           << GetIdentifier() << ", UUID: " << GetUUID().canonical_value();
 }
 
-BluetoothRemoteGattDescriptorBlueZ::~BluetoothRemoteGattDescriptorBlueZ() {}
+BluetoothRemoteGattDescriptorBlueZ::~BluetoothRemoteGattDescriptorBlueZ() =
+    default;
 
 device::BluetoothUUID BluetoothRemoteGattDescriptorBlueZ::GetUUID() const {
   bluez::BluetoothGattDescriptorClient::Properties* properties =

diff --git a/device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.cc b/device/bluetooth/bluez/bluetooth_service_attribute_value_bluez.cc
@@ -49,6 +49,7 @@ operator=(const BluetoothServiceAttributeValueBlueZ& attribute) {
   return *this;
 }
 
-BluetoothServiceAttributeValueBlueZ::~BluetoothServiceAttributeValueBlueZ() {}
+BluetoothServiceAttributeValueBlueZ::~BluetoothServiceAttributeValueBlueZ() =
+    default;
 
 }  // namespace bluez
diff --git a/device/bluetooth/bluez/bluetooth_service_record_bluez.cc b/device/bluetooth/bluez/bluetooth_service_record_bluez.cc
@@ -10,14 +10,14 @@
 
 namespace bluez {
 
-BluetoothServiceRecordBlueZ::BluetoothServiceRecordBlueZ() {}
+BluetoothServiceRecordBlueZ::BluetoothServiceRecordBlueZ() = default;
 
 BluetoothServiceRecordBlueZ::BluetoothServiceRecordBlueZ(
     const BluetoothServiceRecordBlueZ& record) {
   this->attributes_ = record.attributes_;
 }
 
-BluetoothServiceRecordBlueZ::~BluetoothServiceRecordBlueZ() {}
+BluetoothServiceRecordBlueZ::~BluetoothServiceRecordBlueZ() = default;
 
 const std::vector<uint16_t> BluetoothServiceRecordBlueZ::GetAttributeIds()
     const {