Skip to content

Commit

Permalink
Remove unused methods in std::string StringTraits
Browse files Browse the repository at this point in the history
IsNull and SetToNull aren't needed as the STL string type doesn't use
nullable_is_same_type.

Change-Id: I0770b42e275e3026749c5409015c4b79941ea56f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386744
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Cr-Commit-Position: refs/heads/master@{#803654}
  • Loading branch information
hferreiro authored and Commit Bot committed Sep 1, 2020
1 parent 54cd2ba commit 5159cfc
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions mojo/public/cpp/bindings/string_traits_stl.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,6 @@ namespace mojo {

template <>
struct StringTraits<std::string> {
static bool IsNull(const std::string& input) {
// std::string is always converted to non-null mojom string.
return false;
}

static void SetToNull(std::string* output) {
// std::string doesn't support null state. Set it to empty instead.
output->clear();
}

static const std::string& GetUTF8(const std::string& input) { return input; }

static bool Read(StringDataView input, std::string* output) {
Expand Down

0 comments on commit 5159cfc

Please sign in to comment.