Skip to content

Commit

Permalink
Add // nogncheck for broker_service.h in //chromecast/browser
Browse files Browse the repository at this point in the history
Add // nongncheck for broker_service.h for a few files in
//chromecast/browser, otherwise the gn check will fail for gn
check on missing the gn target broker_service, even though it
is included already by arg  and buildflag
ENABLE_EXTERNAL_MOJO_SERVICES.

Bug: 169104485
Test: CQ
Change-Id: Iffe34806ed2e51fdb91216425a6133d0d5ba826b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533735
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Sean Topping <seantopping@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Zhaoxin Liang <zxliang@google.com>
Cr-Commit-Position: refs/heads/master@{#826964}
  • Loading branch information
zxliang authored and Commit Bot committed Nov 12, 2020
1 parent e8a4d4f commit 4ae98be
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion chromecast/browser/cast_content_browser_client.cc
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@
#endif

#if BUILDFLAG(ENABLE_EXTERNAL_MOJO_SERVICES)
#include "chromecast/external_mojo/broker_service/broker_service.h"
#include "chromecast/external_mojo/broker_service/broker_service.h" // nogncheck
#endif

#if (defined(OS_LINUX) || defined(OS_CHROMEOS)) && defined(USE_OZONE)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
#endif // BUILDFLAG(ENABLE_CAST_RENDERER)

#if BUILDFLAG(ENABLE_EXTERNAL_MOJO_SERVICES)
#include "chromecast/external_mojo/broker_service/broker_service.h"
#include "chromecast/external_mojo/broker_service/broker_service.h" // nogncheck
#endif

#if (defined(OS_LINUX) || defined(OS_CHROMEOS)) && defined(USE_OZONE)
Expand Down
2 changes: 1 addition & 1 deletion chromecast/browser/cast_overlay_manifests.cc
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
#include "services/service_manager/public/cpp/manifest_builder.h"

#if BUILDFLAG(ENABLE_EXTERNAL_MOJO_SERVICES)
#include "chromecast/external_mojo/broker_service/broker_service.h"
#include "chromecast/external_mojo/broker_service/broker_service.h" // nogncheck
#endif

#if defined(USE_INTERNAL_OVERLAY_MANIFESTS)
Expand Down

0 comments on commit 4ae98be

Please sign in to comment.