Skip to content

Commit

Permalink
Roll src/breakpad/src 027db3c04..9e9c3563a (fix arm64 stack overflow)
Browse files Browse the repository at this point in the history
This roll pulls a major breakpad fix affecting mainly arm64 (see
crbug.com/534738) and causing a loss of crash reports (mainly on
Android M+)

****** Note for TPMs and stability sheriffs ******
It is possible that the number of Android crashes reported for arm64
will suddenly bump up after this change. This is an expected
consequence of fixing the cause of crash-report loss.

Revision log:
https://chromium.googlesource.com/breakpad/breakpad/src.git/+log/027db3c04fbea96f3efa8e1f722ffff11b19a085..9e9c3563a356ce441eed044257a54aa8b4114693

9e9c356 Linux ExceptionHandler: don't allocate the CrashContext on the stack
3163a73 Fixup a bad strcmp call landed in previous commit
164ba52 Fix Mac Breakpad host tools to build in Linux cross-compile
6a0d328 solaris: fix spurious ;

BUG=534738
TBR=mark@chromium.org

Review URL: https://codereview.chromium.org/1361563002

Cr-Commit-Position: refs/heads/master@{#350540}
  • Loading branch information
primiano authored and Commit bot committed Sep 24, 2015
1 parent 9d18db0 commit 49c1770
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ allowed_hosts = [

deps = {
'src/breakpad/src':
Var('chromium_git') + '/breakpad/breakpad/src.git' + '@' + '027db3c04fbea96f3efa8e1f722ffff11b19a085',
Var('chromium_git') + '/breakpad/breakpad/src.git' + '@' + '9e9c3563a356ce441eed044257a54aa8b4114693',

'src/buildtools':
Var('chromium_git') + '/chromium/buildtools.git' + '@' + Var('buildtools_revision'),
Expand Down
4 changes: 2 additions & 2 deletions breakpad/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ if (current_toolchain == host_toolchain && is_mac) {
"src/common/language.cc",
"src/common/mac/arch_utilities.cc",
"src/common/mac/arch_utilities.h",
"src/common/mac/dump_syms.mm",
"src/common/mac/dump_syms.cc",
"src/common/mac/file_id.cc",
"src/common/mac/macho_id.cc",
"src/common/mac/macho_reader.cc",
Expand All @@ -236,7 +236,7 @@ if (current_toolchain == host_toolchain && is_mac) {
"src/common/module.cc",
"src/common/stabs_reader.cc",
"src/common/stabs_to_module.cc",
"src/tools/mac/dump_syms/dump_syms_tool.mm",
"src/tools/mac/dump_syms/dump_syms_tool.cc",
]

# For src/common/stabs_reader.h.
Expand Down
4 changes: 2 additions & 2 deletions breakpad/breakpad.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@
'src/common/language.cc',
'src/common/mac/arch_utilities.cc',
'src/common/mac/arch_utilities.h',
'src/common/mac/dump_syms.mm',
'src/common/mac/dump_syms.cc',
'src/common/mac/file_id.cc',
'src/common/mac/macho_id.cc',
'src/common/mac/macho_reader.cc',
Expand All @@ -209,7 +209,7 @@
'src/common/module.cc',
'src/common/stabs_reader.cc',
'src/common/stabs_to_module.cc',
'src/tools/mac/dump_syms/dump_syms_tool.mm',
'src/tools/mac/dump_syms/dump_syms_tool.cc',
],
'defines': [
# For src/common/stabs_reader.h.
Expand Down

0 comments on commit 49c1770

Please sign in to comment.