Skip to content

Commit

Permalink
Add documentation for Crosapi/BrowserService.
Browse files Browse the repository at this point in the history
BrowserService is always the wrong interface to use when code in ash
needs to communiate with Lacros. This CL updates the documentation to
indicate this.

Change-Id: I253252777051d784dc9159d9b0f5621a295c9d9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2782224
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Roland Bock <rbock@google.com>
Cr-Commit-Position: refs/heads/master@{#866814}
  • Loading branch information
erikchen authored and Chromium LUCI CQ committed Mar 25, 2021
1 parent 345c2bd commit 495d496
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions chromeos/crosapi/mojom/crosapi.mojom
Original file line number Diff line number Diff line change
Expand Up @@ -373,8 +373,14 @@ struct BrowserInitParams {

// BrowserService defines the APIs that live in a browser (such as
// lacros-chrome) and are accessed from ash-chrome.
// IMPORTANT NOTE: If you are exposing a new capability from Lacros to Ash,
// create a new mojom file. See automation.mojom for an example. This interface
// has accidentally become a kitchen sink for different features. This was not
// intentional.
//
// Next MinVersion: 11.
// Next ID: 9
//
[Stable, Uuid="4e04dc16-b34c-40fd-9e3f-3c55c2c6cf91",
RenamedFrom="crosapi.mojom.LacrosChromeService"]
interface BrowserService {
Expand Down

0 comments on commit 495d496

Please sign in to comment.