Skip to content

Commit

Permalink
Convert indirect uses of TestingFactoryFunction
Browse files Browse the repository at this point in the history
TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//extensions/browser/api/feedback_private.

This CL was uploaded by git cl split.

R=afakhry@chromium.org

Bug: 809610
Change-Id: I41eb7e5f4a7b0286c0e3338e1b1792f38c7fdfdb
Reviewed-on: https://chromium-review.googlesource.com/c/1259017
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596593}
  • Loading branch information
sdefresne authored and Commit Bot committed Oct 4, 2018
1 parent b585e92 commit 48480cf
Showing 1 changed file with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,9 @@ void FeedbackPrivateApiUnittestBase::SetUp() {
// that there is always a valid ApiResourceManager<LogSourceResource> when
// subsequent unit tests are running.
ApiResourceManager<LogSourceResource>::GetFactoryInstance()
->SetTestingFactoryAndUse(browser_context(),
ApiResourceManagerTestFactory);
->SetTestingFactoryAndUse(
browser_context(),
base::BindRepeating(&ApiResourceManagerTestFactory));
}

void FeedbackPrivateApiUnittestBase::TearDown() {
Expand Down

0 comments on commit 48480cf

Please sign in to comment.