Skip to content

Commit

Permalink
Make //chrome/chrome_cleaner visible to network annotation check
Browse files Browse the repository at this point in the history
R=nicolaso

Bug: 1031880
Change-Id: I345dc5f7d24f46cdca98a8ab12bebcd67ae05dbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955957
Auto-Submit: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723832}
  • Loading branch information
JoeNotCharlesGoogle authored and Commit Bot committed Dec 11, 2019
1 parent e4f48bb commit 448d37b
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 2 deletions.
4 changes: 4 additions & 0 deletions BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -834,6 +834,10 @@ if ((is_linux || is_win) && enable_remoting && !use_ozone) {
"//remoting/host:host",
"//tools/traffic_annotation/summary:annotations_xml",
]

if (is_win) {
deps += [ "//chrome/chrome_cleaner:shipped_binaries" ]
}
}
}

Expand Down
13 changes: 11 additions & 2 deletions chrome/chrome_cleaner/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,16 @@ test("chrome_cleaner_unittests") {
}
}

group("shipped_binaries") {
# This group is used for network annotation check test.
visibility += [ "//.:shipped_binaries" ]

deps = [
"//chrome/chrome_cleaner/executables:chrome_cleanup_tool",
"//chrome/chrome_cleaner/executables:software_reporter_tool",
]
}

group("chrome_cleaner") {
testonly = true

Expand All @@ -121,8 +131,7 @@ group("chrome_cleaner") {

deps = [
":chrome_cleaner_unittests",
"//chrome/chrome_cleaner/executables:chrome_cleanup_tool",
"//chrome/chrome_cleaner/executables:software_reporter_tool",
":shipped_binaries",
"//chrome/chrome_cleaner/tools:generate_test_uws",
]

Expand Down

0 comments on commit 448d37b

Please sign in to comment.