Skip to content

Commit

Permalink
Reland "Add web tests virtual suite for audio service - Take 2"
Browse files Browse the repository at this point in the history
This reverts commit 75b3879.

Reason for revert: Adding expectation to address Linux Leak failure

Original change's description:
> Revert "Add web tests virtual suite for audio service - Take 2"
> 
> This reverts commit 8d64895.
> 
> Reason for revert: Causing failures on WebKit Linux Leak
> 
> Failure output:
> 06:31:06.621 2998 worker/6 virtual/audio-service/media/autoplay/document-user-activation.html failed:
> 06:31:06.621 2998 worker/6  leak detected: ({"numberOfLiveContextLifecycleStateObservers":[0,2],"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,135],"numberOfLiveResourceFetchers":[1,2],"numberOfLiveResources":[0,2]})
> 
> Original change's description:
> > Add web tests virtual suite for audio service - Take 2
> > 
> > Adds extra expectations with respect to reverted
> > https://chromium-review.googlesource.com/c/chromium/src/+/1715811
> > 
> > Bug: 976696
> > Change-Id: If36df0fd21b059c2eb212a0d1869c9ff82951c66
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732088
> > Reviewed-by: Armando Miraglia <armax@chromium.org>
> > Commit-Queue: Guido Urdaneta <guidou@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#683565}
> 
> TBR=guidou@chromium.org,armax@chromium.org
> 
> Change-Id: I15488e069bee7e6e1282bcc78dfe2088339b7036
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 976696
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733508
> Reviewed-by: Chris Sharp <csharp@chromium.org>
> Commit-Queue: Chris Sharp <csharp@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#683600}

TBR=csharp@chromium.org,guidou@chromium.org,armax@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 976696
Change-Id: I9172e204adef935eb4ae4a60045a54b6c9c157f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735378
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683979}
  • Loading branch information
Guido Urdaneta authored and Commit Bot committed Aug 5, 2019
1 parent 0f6f3d3 commit 35ad15e
Show file tree
Hide file tree
Showing 8 changed files with 151 additions and 0 deletions.
1 change: 1 addition & 0 deletions third_party/blink/web_tests/LeakExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ crbug.com/878727 [ Linux ] virtual/threaded/http/tests/devtools/tracing/timeline
crbug.com/862029 [ Linux ] virtual/threaded/http/tests/devtools/tracing/timeline-misc/timeline-window-filter.js [ Pass Leak ]

crbug.com/733494 [ Linux ] media/autoplay/document-user-activation.html [ Pass Leak ]
crbug.com/733494 [ Linux ] virtual/audio-service/media/autoplay/document-user-activation.html [ Pass Leak ]

# Sheriff 2019-01-04
crbug.com/919117 [ Linux ] virtual/mouseevent_fractional/fast/events/middleClickAutoscroll-drag.html [ Pass Leak ]
Expand Down
4 changes: 4 additions & 0 deletions third_party/blink/web_tests/NeverFixTests
Original file line number Diff line number Diff line change
Expand Up @@ -1622,6 +1622,7 @@ crbug.com/457718 external/wpt/css/css-pseudo/marker-font-properties.html [ WontF

# Requires --use-fake-ui-for-media-stream to run.
external/wpt/mediacapture-streams/MediaStream-default-feature-policy.https.html [ WontFix ]
virtual/audio-service/external/wpt/mediacapture-streams/MediaStream-default-feature-policy.https.html [ WontFix ]

# These directories have manual tests that don't have to run with
# run_web_tests.py; see https://crbug.com/359838.
Expand Down Expand Up @@ -2137,6 +2138,8 @@ virtual/blink-cors/external/wpt/xhr/send-authentication-existing-session-manual.
virtual/blink-cors/external/wpt/xhr/send-authentication-prompt-2-manual.htm [ WontFix ]
virtual/feature-policy-permissions/external/wpt/mediacapture-streams/MediaStream-MediaElement-preload-none-manual.https.html [ WontFix ]
virtual/feature-policy-permissions/external/wpt/mediacapture-streams/MediaStreamTrack-end-manual.https.html [ WontFix ]
virtual/audio-service/external/wpt/mediacapture-streams/MediaStream-MediaElement-preload-none-manual.https.html [ WontFix ]
virtual/audio-service/external/wpt/mediacapture-streams/MediaStreamTrack-end-manual.https.html [ WontFix ]
virtual/omt-worker-fetch/external/wpt/service-workers/service-worker/fetch-event-is-history-backward-navigation-manual.https.html [ WontFix ]
virtual/omt-worker-fetch/external/wpt/service-workers/service-worker/fetch-event-is-history-forward-navigation-manual.https.html [ WontFix ]
virtual/omt-worker-fetch/external/wpt/service-workers/service-worker/fetch-event-is-reload-navigation-manual.https.html [ WontFix ]
Expand Down Expand Up @@ -2245,6 +2248,7 @@ crbug.com/946022 [ Win7 ] images/image-click-scale-restore-zoomed-image.html [ W
crbug.com/946022 [ Win7 ] images/image-zoom-to-25.html [ WontFix ]
crbug.com/946022 [ Win7 ] images/image-zoom-to-500.html [ WontFix ]
crbug.com/946022 [ Win7 ] media/controls/overflow-menu-hide-on-resize.html [ WontFix ]
crbug.com/946022 [ Win7 ] virtual/audio-service/media/controls/overflow-menu-hide-on-resize.html [ WontFix ]
crbug.com/946022 [ Win7 ] paint/invalidation/resize-iframe-text.html [ WontFix ]
crbug.com/946022 [ Win7 ] paint/invalidation/scroll/scrollbar-damage-and-full-viewport-repaint.html [ WontFix ]
crbug.com/946022 [ Win7 ] paint/invalidation/window-resize/ [ WontFix ]
Expand Down
38 changes: 38 additions & 0 deletions third_party/blink/web_tests/SlowTests
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ crbug.com/24182 jquery/offset.html [ Slow ]
crbug.com/24182 jquery/traversing.html [ Slow ]
crbug.com/24182 media/controls/controls-cast-do-not-fade-out.html [ Slow ]
crbug.com/24182 media/controls/controls-cast-overlay-slow-fade.html [ Slow ]
crbug.com/24182 virtual/audio-service/media/controls/controls-cast-do-not-fade-out.html [ Slow ]
crbug.com/24182 virtual/audio-service/media/controls/controls-cast-overlay-slow-fade.html [ Slow ]
crbug.com/24182 svg/filters/big-sized-filter.svg [ Slow ]
crbug.com/24182 tables/mozilla/other/slashlogo.html [ Slow ]
crbug.com/24182 fast/canvas/color-space/canvas-colorManaged-toBlob-toDataURL.html [ Slow ]
Expand Down Expand Up @@ -117,6 +119,10 @@ crbug.com/73609 http/tests/media/video-play-stall.html [ Slow ]
crbug.com/73609 http/tests/media/video-preload-metadata.html [ Slow ]
crbug.com/869829 http/tests/media/video-cancel-load.html [ Slow ]
crbug.com/870259 http/tests/media/video-throttled-load-metadata.html [ Slow ]
crbug.com/73609 virtual/audio-service/http/tests/media/video-play-stall.html [ Slow ]
crbug.com/73609 virtual/audio-service/http/tests/media/video-preload-metadata.html [ Slow ]
crbug.com/869829 virtual/audio-service/http/tests/media/video-cancel-load.html [ Slow ]
crbug.com/870259 virtual/audio-service/http/tests/media/video-throttled-load-metadata.html [ Slow ]

# Many of the virtual animations tests are slow.
crbug.com/243871 virtual/threaded/fast/scroll-behavior/ [ Slow ]
Expand Down Expand Up @@ -150,6 +156,7 @@ crbug.com/336481 http/tests/devtools/jump-to-previous-editing-location.js [ Slow
crbug.com/346259 http/tests/websocket/no-crash-on-cookie-flood.html [ Slow ]

crbug.com/522646 http/tests/media/encrypted-media/encrypted-media-encrypted-event-different-origin.html [ Slow ]
crbug.com/522646 virtual/audio-service/http/tests/media/encrypted-media/encrypted-media-encrypted-event-different-origin.html [ Slow ]
crbug.com/411164 [ Win ] http/tests/security/powerfulFeatureRestrictions/serviceworker-on-insecure-origin.html [ Slow ]
crbug.com/411164 [ Win ] virtual/blink-cors/http/tests/security/powerfulFeatureRestrictions/serviceworker-on-insecure-origin.html [ Slow ]
crbug.com/510337 http/tests/devtools/console/console-format.js [ Slow ]
Expand Down Expand Up @@ -216,6 +223,7 @@ crbug.com/660468 [ Linux ] storage/indexeddb/observer-workers.html [ Slow ]

# Media controls tests have to wait for panel to fade out.
crbug.com/722825 media/controls/video-enter-exit-fullscreen-without-hovering-doesnt-show-controls.html [ Slow ]
crbug.com/722825 virtual/audio-service/media/controls/video-enter-exit-fullscreen-without-hovering-doesnt-show-controls.html [ Slow ]

crbug.com/719298 fast/dnd/dropEffect-for-effectAllowed.html [ Slow ]

Expand All @@ -229,6 +237,7 @@ crbug.com/451577 [ Linux ] http/tests/devtools/elements/user-properties.js [ Slo
crbug.com/451577 [ Linux ] http/tests/devtools/layers/layer-canvas-log.js [ Slow ]

crbug.com/793771 media/controls/scrubbing.html [ Slow ]
crbug.com/793771 virtual/audio-service/media/controls/scrubbing.html [ Slow ]

# These tests need to do many iterations and so can't be fast.
crbug.com/748418 http/tests/streams/chromium/deep-recursion-getwriter.html [ Slow ]
Expand Down Expand Up @@ -269,8 +278,10 @@ crbug.com/853977 [ Linux ] virtual/streaming-preload/http/tests/fetch/chromium/r
crbug.com/864887 [ Mac ] fast/scroll-snap/snaps-after-scrollbar-scrolling.html [ Slow ]

crbug.com/865262 [ Mac ] media/controls/text-track-menu-pointer-selection.html [ Slow ]
crbug.com/865262 [ Mac ] virtual/audio-service/media/controls/text-track-menu-pointer-selection.html [ Slow ]

crbug.com/942951 media/controls/controls-layout-in-different-size.html [ Slow ]
crbug.com/942951 virtual/audio-service/media/controls/controls-layout-in-different-size.html [ Slow ]

crbug.com/910627 webexposed/global-interface-listing-shared-worker.html [ Slow ]
crbug.com/910627 virtual/stable/webexposed/global-interface-listing-shared-worker.html [ Slow ]
Expand Down Expand Up @@ -435,6 +446,11 @@ crbug.com/874695 http/tests/media/preload-conditions.html [ Slow ]
crbug.com/874695 http/tests/media/video-buffered.html [ Slow ]
crbug.com/874695 http/tests/media/video-load-metadata-decode-error.html [ Slow ]
crbug.com/874695 http/tests/media/video-play-stall-before-meta-data.html [ Slow ]
crbug.com/874695 virtual/audio-service/http/tests/media/controls/toggle-class-with-state-source-buffer.html [ Slow ]
crbug.com/874695 virtual/audio-service/http/tests/media/preload-conditions.html [ Slow ]
crbug.com/874695 virtual/audio-service/http/tests/media/video-buffered.html [ Slow ]
crbug.com/874695 virtual/audio-service/http/tests/media/video-load-metadata-decode-error.html [ Slow ]
crbug.com/874695 virtual/audio-service/http/tests/media/video-play-stall-before-meta-data.html [ Slow ]
crbug.com/874695 http/tests/misc/adopt-iframe-src-attr-after-remove.html [ Slow ]
crbug.com/874695 http/tests/misc/async-script-removed.html [ Slow ]
crbug.com/874695 http/tests/misc/client-hints-accept-meta-preloader.html [ Slow ]
Expand Down Expand Up @@ -493,6 +509,27 @@ crbug.com/874695 media/video-controls-show-on-focus.html [ Slow ]
crbug.com/874695 media/video-controls-visibility-multimodal-mouse-after-touch.html [ Slow ]
crbug.com/874695 media/video-controls-visibility-multimodal-touch-after-mouse.html [ Slow ]
crbug.com/874695 media/video-played-collapse.html [ Slow ]
crbug.com/874695 virtual/audio-service/media/audio-controls-do-not-fade-out.html [ Slow ]
crbug.com/874695 virtual/audio-service/media/autoplay-muted.html [ Slow ]
crbug.com/874695 virtual/audio-service/media/color-profile-video-seek-filter.html [ Slow ]
crbug.com/874695 virtual/audio-service/media/controls/video-enter-exit-fullscreen-while-hovering-shows-controls.html [ Slow ]
crbug.com/874695 virtual/audio-service/media/encrypted-media/encrypted-media-onencrypted.html [ Slow ]
crbug.com/874695 virtual/audio-service/media/encrypted-media/encrypted-media-setmediakeys-at-same-time.html [ Slow ]
crbug.com/874695 virtual/audio-service/media/media-controls-tap-show-controls-without-activating.html [ Slow ]
crbug.com/874695 virtual/audio-service/media/media-ended.html [ Slow ]
crbug.com/874695 virtual/audio-service/media/remoteplayback/prompt-twice-throws.html [ Slow ]
crbug.com/874695 virtual/audio-service/media/track/track-cue-gc-wrapper.html [ Slow ]
crbug.com/874695 virtual/audio-service/media/unsupported-rtsp.html [ Slow ]
crbug.com/874695 virtual/audio-service/media/video-controls-always-visible-when-control-hovered.html [ Slow ]
crbug.com/874695 virtual/audio-service/media/video-controls-auto-hide-after-play-by-touch.html [ Slow ]
crbug.com/874695 virtual/audio-service/media/video-controls-dont-show-on-focus-when-disabled.html [ Slow ]
crbug.com/874695 virtual/audio-service/media/video-controls-focus-movement-on-hide.html [ Slow ]
crbug.com/874695 virtual/audio-service/media/video-controls-hide-after-touch-on-control.html [ Slow ]
crbug.com/874695 virtual/audio-service/media/video-controls-hide-on-move-outside-controls.html [ Slow ]
crbug.com/874695 virtual/audio-service/media/video-controls-show-on-focus.html [ Slow ]
crbug.com/874695 virtual/audio-service/media/video-controls-visibility-multimodal-mouse-after-touch.html [ Slow ]
crbug.com/874695 virtual/audio-service/media/video-controls-visibility-multimodal-touch-after-mouse.html [ Slow ]
crbug.com/874695 virtual/audio-service/media/video-played-collapse.html [ Slow ]
crbug.com/874695 paint/invalidation/filters/filter-repaint-accelerated-child-with-filter-child.html [ Slow ]
crbug.com/874695 paint/invalidation/filters/filter-repaint-accelerated-on-accelerated-filter.html [ Slow ]
crbug.com/874695 paint/invalidation/filters/filter-repaint-on-accelerated-layer.html [ Slow ]
Expand Down Expand Up @@ -603,6 +640,7 @@ crbug.com/893015 [ Linux ] virtual/streaming-preload/http/tests/fetch/chromium/r
crbug.com/893015 [ Linux ] virtual/streaming-preload/http/tests/fetch/chromium/response-text-gc-crash.html [ Slow ]

crbug.com/914981 [ Mac ] media/controls/overflow-menu-pointer-selection.html [ Slow ]
crbug.com/914981 [ Mac ] virtual/audio-service/media/controls/overflow-menu-pointer-selection.html [ Slow ]
crbug.com/914981 [ Mac ] virtual/mouseevent_fractional/fast/events/no-fake-mousemove.html [ Slow ]
crbug.com/914981 [ Mac ] fast/events/no-fake-mousemove.html [ Slow ]

Expand Down
Loading

0 comments on commit 35ad15e

Please sign in to comment.