Skip to content

Commit

Permalink
[fuchsia] Rename .cmx files for specific unit tests to .test-cmx
Browse files Browse the repository at this point in the history
These unit tests have their own CMX files that enable running
hermetically with run-test-component.

As discussed in the bug, these don't need security review, and renaming
them avoids the presubmit check when maintaining them.

Also remove OWNERS rules that applied only to the renamed files.

Bug: 1132878
Change-Id: I3f211584d164e99455e98c3837ec3cea80c50910
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482028
Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Auto-Submit: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821091}
  • Loading branch information
ddorwin authored and Commit Bot committed Oct 27, 2020
1 parent fbba06f commit 325f5ae
Show file tree
Hide file tree
Showing 6 changed files with 3 additions and 9 deletions.
2 changes: 1 addition & 1 deletion base/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -3348,7 +3348,7 @@ test("base_unittests") {
"//third_party/fuchsia-sdk/sdk/pkg/sys_cpp",
]

manifest = "fuchsia/base_unittests.cmx"
manifest = "fuchsia/base_unittests.test-cmx"
}

if (!is_fuchsia && !is_ios) {
Expand Down
3 changes: 0 additions & 3 deletions base/fuchsia/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,3 @@ file://build/fuchsia/OWNERS
# FilteredServiceDirectory is part of the Fuchsia sandbox.
per-file filtered_service_directory.*=set noparent
per-file filtered_service_directory.*=file://fuchsia/SECURITY_OWNERS

per-file *.cmx=set noparent
per-file *.cmx=file://fuchsia/SECURITY_OWNERS
File renamed without changes.
2 changes: 1 addition & 1 deletion media/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ test("media_unittests") {
"//media/fuchsia/audio:unittests",
"//media/fuchsia/cdm/service:unittests",
]
manifest = "//media/fuchsia/media_unittests.cmx"
manifest = "//media/fuchsia/media_unittests.test-cmx"
}

if (enable_media_remoting) {
Expand Down
5 changes: 1 addition & 4 deletions media/fuchsia/OWNERS
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
sergeyu@chromium.org
yucliu@chromium.org
wez@chromium.org

per-file *.cmx=set noparent
per-file *.cmx=file://fuchsia/SECURITY_OWNERS
yucliu@chromium.org
File renamed without changes.

0 comments on commit 325f5ae

Please sign in to comment.