Skip to content

Commit

Permalink
Disable flaky tests
Browse files Browse the repository at this point in the history
The tests in question are flaky on Mac as well:
- https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyZwsSBUZsYWtlIlxjaHJvbWl1bUBjb250ZW50X2Jyb3dzZXJ0ZXN0c0BNb3VzZUxhdGVuY3lCcm93c2VyVGVzdC5Db2FsZXNjZWRNb3VzZU1vdmVzQ29ycmVjdGx5VGVybWluYXRlZAw
- https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyYgsSBUZsYWtlIldjaHJvbWl1bUBjb250ZW50X2Jyb3dzZXJ0ZXN0c0BNb3VzZUxhdGVuY3lCcm93c2VyVGVzdC5Nb3VzZURvd25BbmRVcFJlY29yZGVkV2l0aG91dFN3YXAM

Also, these are currently blocking submission of
https://crrev.com/c/2159706 which make the failure reproducible due to
timing changes.

Change-Id: If7f2818f56696f0d458e0329699ec1d088d937f0
Bug: 801629, 800303, 815363
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2179483
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Andrew Shulaev <ddrone@google.com>
Cr-Commit-Position: refs/heads/master@{#765076}
  • Loading branch information
ddrone authored and Commit Bot committed May 4, 2020
1 parent 05c9fd9 commit 325562c
Showing 1 changed file with 4 additions and 20 deletions.
24 changes: 4 additions & 20 deletions content/browser/renderer_host/input/mouse_latency_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -305,17 +305,9 @@ class MouseLatencyBrowserTest : public ContentBrowserTest {
// MouseDown events in the case where no swap is generated.
// Disabled on Android because we don't support synthetic mouse input on
// Android (crbug.com/723618).
// Disabled on Windows due to flakyness (https://crbug.com/800303).
// Disabled on Linux due to flakyness (https://crbug.com/815363).
#if defined(OS_ANDROID) || defined(OS_WIN) || defined(OS_LINUX)
#define MAYBE_MouseDownAndUpRecordedWithoutSwap \
DISABLED_MouseDownAndUpRecordedWithoutSwap
#else
#define MAYBE_MouseDownAndUpRecordedWithoutSwap \
MouseDownAndUpRecordedWithoutSwap
#endif
// Disabled on due to flakiness (https://crbug.com/800303, https://crbug.com/815363).
IN_PROC_BROWSER_TEST_F(MouseLatencyBrowserTest,
MAYBE_MouseDownAndUpRecordedWithoutSwap) {
DISABLED_MouseDownAndUpRecordedWithoutSwap) {
LoadURL();

auto filter = std::make_unique<InputMsgWatcher>(
Expand Down Expand Up @@ -358,17 +350,9 @@ IN_PROC_BROWSER_TEST_F(MouseLatencyBrowserTest,
// events in the case where events are coalesced. (crbug.com/771165).
// Disabled on Android because we don't support synthetic mouse input on Android
// (crbug.com/723618).
// http://crbug.com/801629 : Flaky on Linux and Windows, and Mac with
// --enable-features=VizDisplayCompositor
#if defined(OS_ANDROID) || defined(OS_WIN) || defined(OS_LINUX)
#define MAYBE_CoalescedMouseMovesCorrectlyTerminated \
DISABLED_CoalescedMouseMovesCorrectlyTerminated
#else
#define MAYBE_CoalescedMouseMovesCorrectlyTerminated \
CoalescedMouseMovesCorrectlyTerminated
#endif
// http://crbug.com/801629 : Flaky on multiple platforms.
IN_PROC_BROWSER_TEST_F(MouseLatencyBrowserTest,
MAYBE_CoalescedMouseMovesCorrectlyTerminated) {
DISABLED_CoalescedMouseMovesCorrectlyTerminated) {
LoadURL();

StartTracing();
Expand Down

0 comments on commit 325562c

Please sign in to comment.