Skip to content

Commit

Permalink
Change includes of histogram.h to histogram_macros.h.
Browse files Browse the repository at this point in the history
This is another pass of migration of includes for users of histogram
macros. This doesn't fully complete the migration, but gets us closer
to the end result.

A few files needed to include both headers as they use both
macros and the raw API.

BUG=416479
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=jam@chromium.org

Review-Url: https://codereview.chromium.org/2293583002
Cr-Commit-Position: refs/heads/master@{#415067}
  • Loading branch information
asvitkine-chromium authored and Commit bot committed Aug 30, 2016
1 parent a8d8427 commit 3033081
Show file tree
Hide file tree
Showing 108 changed files with 110 additions and 101 deletions.
2 changes: 1 addition & 1 deletion base/files/important_file_writer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
#include "base/files/file_util.h"
#include "base/logging.h"
#include "base/macros.h"
#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "base/numerics/safe_conversions.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h"
Expand Down
2 changes: 1 addition & 1 deletion base/threading/sequenced_worker_pool.cc
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
#endif

#if !defined(OS_NACL)
#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#endif

namespace base {
Expand Down
2 changes: 1 addition & 1 deletion cc/debug/frame_rate_counter.cc
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#include <limits>

#include "base/memory/ptr_util.h"
#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "cc/trees/proxy.h"

namespace cc {
Expand Down
2 changes: 1 addition & 1 deletion cc/output/ca_layer_overlay.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

#include "cc/output/ca_layer_overlay.h"

#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "cc/quads/render_pass_draw_quad.h"
#include "cc/quads/solid_color_draw_quad.h"
#include "cc/quads/stream_video_draw_quad.h"
Expand Down
2 changes: 1 addition & 1 deletion cc/output/direct_renderer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#include <utility>
#include <vector>

#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "base/numerics/safe_conversions.h"
#include "base/trace_event/trace_event.h"
#include "cc/base/math_util.h"
Expand Down
2 changes: 1 addition & 1 deletion cc/scheduler/compositor_timing_history.cc
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#include <stdint.h>

#include "base/memory/ptr_util.h"
#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "base/trace_event/trace_event.h"
#include "cc/debug/rendering_stats_instrumentation.h"

Expand Down
2 changes: 1 addition & 1 deletion cc/tiles/tile_draw_info.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

#include "cc/tiles/tile_draw_info.h"

#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "cc/base/math_util.h"

namespace cc {
Expand Down
2 changes: 1 addition & 1 deletion cc/trees/layer_tree_host.cc
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
#include "base/command_line.h"
#include "base/location.h"
#include "base/memory/ptr_util.h"
#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "base/numerics/safe_math.h"
#include "base/single_thread_task_runner.h"
#include "base/stl_util.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
#include "base/command_line.h"
#include "base/macros.h"
#include "base/memory/ptr_util.h"
#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "base/stl_util.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.h"

#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "base/optional.h"
#include "base/rand_util.h"
#include "base/time/time.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#include <utility>

#include "base/callback.h"
#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "base/strings/utf_string_conversions.h"
#include "components/dom_distiller/content/browser/distiller_javascript_utils.h"
#include "components/dom_distiller/content/browser/web_contents_main_frame_observer.h"
Expand Down
2 changes: 1 addition & 1 deletion components/domain_reliability/context.cc
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#include "base/bind.h"
#include "base/json/json_writer.h"
#include "base/logging.h"
#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "base/metrics/sparse_histogram.h"
#include "base/rand_util.h"
#include "base/values.h"
Expand Down
2 changes: 1 addition & 1 deletion components/history/core/browser/download_database.cc
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

#include "base/debug/alias.h"
#include "base/files/file_path.h"
#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "base/rand_util.h"
#include "base/stl_util.h"
#include "base/strings/stringprintf.h"
Expand Down
2 changes: 1 addition & 1 deletion components/history/core/browser/history_database.cc
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
#include "base/command_line.h"
#include "base/containers/hash_tables.h"
#include "base/files/file_util.h"
#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "base/numerics/safe_conversions.h"
#include "base/rand_util.h"
#include "base/strings/string_util.h"
Expand Down
2 changes: 1 addition & 1 deletion components/history/core/browser/in_memory_database.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

#include "base/files/file_path.h"
#include "base/logging.h"
#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "base/strings/utf_string_conversions.h"
#include "base/time/time.h"
#include "build/build_config.h"
Expand Down
2 changes: 1 addition & 1 deletion components/history/core/browser/top_sites_database.cc
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

#include "base/files/file_util.h"
#include "base/memory/ref_counted.h"
#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "base/strings/string_split.h"
#include "base/strings/string_util.h"
#include "components/history/core/browser/history_types.h"
Expand Down
2 changes: 1 addition & 1 deletion components/history/core/browser/web_history_service.cc
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#include "base/command_line.h"
#include "base/json/json_reader.h"
#include "base/json/json_writer.h"
#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "base/optional.h"
#include "base/stl_util.h"
#include "base/strings/string_number_conversions.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#include <stdint.h>

#include "base/macros.h"
#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "base/time/tick_clock.h"

namespace memory_pressure {
Expand Down
2 changes: 1 addition & 1 deletion components/metrics/profiler/tracking_synchronizer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

#include "base/bind.h"
#include "base/callback.h"
#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "base/threading/thread.h"
#include "base/threading/thread_task_runner_handle.h"
#include "base/tracked_objects.h"
Expand Down
2 changes: 1 addition & 1 deletion components/metrics/stability_metrics_helper.cc
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#include <vector>

#include "base/logging.h"
#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "base/metrics/sparse_histogram.h"
#include "build/build_config.h"
#include "components/metrics/metrics_pref_names.h"
Expand Down
1 change: 1 addition & 0 deletions components/ntp_tiles/most_visited_sites.cc
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
#include "base/feature_list.h"
#include "base/metrics/field_trial.h"
#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "base/metrics/sparse_histogram.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h"
Expand Down
2 changes: 1 addition & 1 deletion components/omnibox/browser/history_url_provider.cc
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
#include "base/location.h"
#include "base/macros.h"
#include "base/message_loop/message_loop.h"
#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "base/single_thread_task_runner.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
Expand Down
2 changes: 1 addition & 1 deletion components/omnibox/browser/omnibox_edit_model.cc
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
#include "base/auto_reset.h"
#include "base/format_macros.h"
#include "base/macros.h"
#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "base/metrics/user_metrics.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h"
Expand Down
2 changes: 1 addition & 1 deletion components/omnibox/browser/url_index_private_data.cc
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
#include "base/i18n/break_iterator.h"
#include "base/i18n/case_conversion.h"
#include "base/macros.h"
#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "base/strings/string_split.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
Expand Down
2 changes: 1 addition & 1 deletion components/omnibox/browser/zero_suggest_provider.cc
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#include "base/callback.h"
#include "base/i18n/case_conversion.h"
#include "base/json/json_string_value_serializer.h"
#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "base/metrics/user_metrics.h"
#include "base/strings/string16.h"
#include "base/strings/string_util.h"
Expand Down
2 changes: 1 addition & 1 deletion components/search_engines/default_search_pref_migration.cc
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
#include "base/bind.h"
#include "base/bind_helpers.h"
#include "base/logging.h"
#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_split.h"
#include "base/strings/utf_string_conversions.h"
Expand Down
2 changes: 1 addition & 1 deletion components/sessions/core/session_backend.cc
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
#include "base/files/file_util.h"
#include "base/macros.h"
#include "base/memory/scoped_vector.h"
#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "base/threading/thread_restrictions.h"
#include "build/build_config.h"

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

#include "components/signin/core/browser/signin_status_metrics_provider_base.h"

#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"

SigninStatusMetricsProviderBase::SigninStatusMetricsProviderBase()
: signin_status_(UNKNOWN_SIGNIN_STATUS) {}
Expand Down
2 changes: 1 addition & 1 deletion components/spellcheck/browser/spellcheck_host_metrics.cc
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
#include <stdint.h>

#include "base/md5.h"
#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"

SpellCheckHostMetrics::SpellCheckHostMetrics()
: misspelled_word_count_(0),
Expand Down
2 changes: 1 addition & 1 deletion components/spellcheck/renderer/spellcheck_provider.cc
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#include "components/spellcheck/renderer/spellcheck_provider.h"

#include "base/command_line.h"
#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "components/spellcheck/common/spellcheck_marker.h"
#include "components/spellcheck/common/spellcheck_messages.h"
#include "components/spellcheck/common/spellcheck_result.h"
Expand Down
2 changes: 1 addition & 1 deletion components/sync/core/shared_model_type_processor.cc
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#include "base/bind.h"
#include "base/location.h"
#include "base/memory/ptr_util.h"
#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "base/threading/thread_task_runner_handle.h"
#include "components/sync/core/activation_context.h"
#include "components/sync/core/processor_entity_tracker.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
#include "base/bind.h"
#include "base/callback.h"
#include "base/location.h"
#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "base/sequenced_task_runner.h"
#include "components/sync/core/attachments/attachment_util.h"
#include "components/sync/core_impl/attachments/proto/attachment_store.pb.h"
Expand Down
2 changes: 1 addition & 1 deletion components/sync/core_impl/sync_encryption_handler_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
#include "base/bind.h"
#include "base/json/json_string_value_serializer.h"
#include "base/location.h"
#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "base/single_thread_task_runner.h"
#include "base/threading/thread_task_runner_handle.h"
#include "base/time/time.h"
Expand Down
2 changes: 1 addition & 1 deletion components/sync/core_impl/sync_manager_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
#include "base/json/json_writer.h"
#include "base/memory/ptr_util.h"
#include "base/memory/ref_counted.h"
#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "base/observer_list.h"
#include "base/strings/string_number_conversions.h"
#include "base/threading/thread_task_runner_handle.h"
Expand Down
2 changes: 1 addition & 1 deletion components/sync/driver/startup_controller.cc
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

#include "base/command_line.h"
#include "base/location.h"
#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "base/single_thread_task_runner.h"
#include "base/strings/string_number_conversions.h"
#include "base/threading/thread_task_runner_handle.h"
Expand Down
2 changes: 1 addition & 1 deletion components/sync/engine_impl/apply_control_data_updates.cc
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

#include <vector>

#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "components/sync/base/cryptographer.h"
#include "components/sync/engine_impl/conflict_resolver.h"
#include "components/sync/engine_impl/conflict_util.h"
Expand Down
2 changes: 1 addition & 1 deletion components/sync/engine_impl/conflict_resolver.cc
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#include <set>
#include <string>

#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "components/sync/base/cryptographer.h"
#include "components/sync/engine/cycle/update_counters.h"
#include "components/sync/engine_impl/conflict_util.h"
Expand Down
2 changes: 1 addition & 1 deletion components/sync/syncable/directory.cc
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

#include "base/base64.h"
#include "base/guid.h"
#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "base/stl_util.h"
#include "base/strings/string_number_conversions.h"
#include "base/trace_event/trace_event.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#include "components/sync/syncable/on_disk_directory_backing_store.h"

#include "base/logging.h"
#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "base/stl_util.h"
#include "components/sync/syncable/syncable-inl.h"

Expand Down
2 changes: 1 addition & 1 deletion components/sync_sessions/favicon_cache.cc
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

#include "base/location.h"
#include "base/macros.h"
#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "base/single_thread_task_runner.h"
#include "base/threading/thread_task_runner_handle.h"
#include "components/favicon/core/favicon_service.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

#include "base/memory/ref_counted.h"
#include "base/message_loop/message_loop.h"
#include "base/metrics/histogram_macros.h"
#include "base/run_loop.h"
#include "components/tracing/common/tracing_messages.h"
#include "ipc/ipc_message.h"
Expand Down
2 changes: 1 addition & 1 deletion components/user_prefs/tracked/pref_hash_filter.cc
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

#include "base/logging.h"
#include "base/macros.h"
#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "base/strings/string_number_conversions.h"
#include "base/time/time.h"
#include "base/values.h"
Expand Down
1 change: 1 addition & 0 deletions components/user_prefs/tracked/tracked_preference_helper.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

#include "base/logging.h"
#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "components/user_prefs/tracked/tracked_preference_histogram_names.h"

TrackedPreferenceHelper::TrackedPreferenceHelper(
Expand Down
2 changes: 1 addition & 1 deletion components/variations/service/variations_service.cc
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
#include "base/build_time.h"
#include "base/command_line.h"
#include "base/memory/ptr_util.h"
#include "base/metrics/histogram.h"
#include "base/metrics/histogram_macros.h"
#include "base/metrics/sparse_histogram.h"
#include "base/strings/string_util.h"
#include "base/sys_info.h"
Expand Down
Loading

0 comments on commit 3033081

Please sign in to comment.