Skip to content

Commit

Permalink
Remove application_cache domain from headless client
Browse files Browse the repository at this point in the history
AppCache is going away.

Bug: 582750, 1084190
Change-Id: I925145aa16cbd62edf2802e2d49fa39f0efa5c49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3194564
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Peter Kvitek <kvitekp@chromium.org>
Auto-Submit: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Peter Kvitek <kvitekp@chromium.org>
Cr-Commit-Position: refs/heads/main@{#926529}
  • Loading branch information
caseq authored and Chromium LUCI CQ committed Sep 29, 2021
1 parent a54d4a0 commit 2b719bc
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 13 deletions.
1 change: 0 additions & 1 deletion headless/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@ grit("resources") {
devtools_domains = [
"accessibility",
"animation",
"application_cache",
"browser",
"cache_storage",
"console",
Expand Down
5 changes: 0 additions & 5 deletions headless/lib/browser/headless_devtools_client_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ HeadlessDevToolsClient::CreateWithExternalHost(ExternalHost* external_host) {
HeadlessDevToolsClientImpl::HeadlessDevToolsClientImpl()
: accessibility_domain_(this),
animation_domain_(this),
application_cache_domain_(this),
browser_domain_(this),
cache_storage_domain_(this),
console_domain_(this),
Expand Down Expand Up @@ -320,10 +319,6 @@ animation::Domain* HeadlessDevToolsClientImpl::GetAnimation() {
return &animation_domain_;
}

application_cache::Domain* HeadlessDevToolsClientImpl::GetApplicationCache() {
return &application_cache_domain_;
}

browser::Domain* HeadlessDevToolsClientImpl::GetBrowser() {
return &browser_domain_;
}
Expand Down
4 changes: 0 additions & 4 deletions headless/public/headless_devtools_client.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,6 @@ class Domain;
namespace animation {
class Domain;
}
namespace application_cache {
class Domain;
}
namespace browser {
class Domain;
}
Expand Down Expand Up @@ -153,7 +150,6 @@ class HEADLESS_EXPORT HeadlessDevToolsClient {
// the capabilities of each domain.
virtual accessibility::Domain* GetAccessibility() = 0;
virtual animation::Domain* GetAnimation() = 0;
virtual application_cache::Domain* GetApplicationCache() = 0;
virtual browser::Domain* GetBrowser() = 0;
virtual cache_storage::Domain* GetCacheStorage() = 0;
virtual console::Domain* GetConsole() = 0;
Expand Down
3 changes: 0 additions & 3 deletions headless/public/internal/headless_devtools_client_impl.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
#include "base/sequenced_task_runner.h"
#include "headless/public/devtools/domains/accessibility.h"
#include "headless/public/devtools/domains/animation.h"
#include "headless/public/devtools/domains/application_cache.h"
#include "headless/public/devtools/domains/browser.h"
#include "headless/public/devtools/domains/cache_storage.h"
#include "headless/public/devtools/domains/console.h"
Expand Down Expand Up @@ -71,7 +70,6 @@ class HEADLESS_EXPORT HeadlessDevToolsClientImpl
// HeadlessDevToolsClient implementation:
accessibility::Domain* GetAccessibility() override;
animation::Domain* GetAnimation() override;
application_cache::Domain* GetApplicationCache() override;
browser::Domain* GetBrowser() override;
cache_storage::Domain* GetCacheStorage() override;
console::Domain* GetConsole() override;
Expand Down Expand Up @@ -197,7 +195,6 @@ class HEADLESS_EXPORT HeadlessDevToolsClientImpl

accessibility::ExperimentalDomain accessibility_domain_;
animation::ExperimentalDomain animation_domain_;
application_cache::ExperimentalDomain application_cache_domain_;
browser::ExperimentalDomain browser_domain_;
cache_storage::ExperimentalDomain cache_storage_domain_;
console::ExperimentalDomain console_domain_;
Expand Down

0 comments on commit 2b719bc

Please sign in to comment.