Skip to content

Commit

Permalink
Remove/replace unnecessary logging.h includes in .cc files (headless)
Browse files Browse the repository at this point in the history
CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved
to the much smaller headers check.h, check_op.h, and notreached.h,
respectively.

This CL updates .cc files to use those headers instead when
possible, with the purpose of saving compile time.

(Split out from https://crrev.com/c/2164525 which also has
notes on how the change was generated.)

Bug: 1031540
Change-Id: Id51234d2a0c73feb06b33585e2ebc74c20ae7f52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164750
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762417}
  • Loading branch information
zmodem authored and Commit Bot committed Apr 24, 2020
1 parent bdc49f7 commit 2b66ec1
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion headless/app/headless_shell_main.cc
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#include "content/public/app/sandbox_helper_win.h"
#include "sandbox/win/src/sandbox_types.h"
#elif defined(OS_MACOSX)
#include "base/logging.h"
#include "base/check.h"
#include "sandbox/mac/seatbelt_exec.h"
#endif

Expand Down
1 change: 0 additions & 1 deletion headless/lib/browser/headless_screen.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

#include <stdint.h>

#include "base/logging.h"
#include "ui/aura/env.h"
#include "ui/aura/window.h"
#include "ui/base/ime/input_method.h"
Expand Down
2 changes: 1 addition & 1 deletion headless/lib/headless_web_contents_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
#include <vector>

#include "base/bind.h"
#include "base/check_op.h"
#include "base/command_line.h"
#include "base/json/json_writer.h"
#include "base/logging.h"
#include "base/run_loop.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
Expand Down
2 changes: 1 addition & 1 deletion headless/public/util/error_reporter.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

#include <sstream>

#include "base/logging.h"
#include "base/check_op.h"
#include "base/strings/string_util.h"

namespace headless {
Expand Down

0 comments on commit 2b66ec1

Please sign in to comment.