Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert of Revert of Substituting legacy protocol with uWeave protocol…
… (patchset #1 id:1 of https://codereview.chromium.org/2189913002/ ) Reason for revert: The memory leak that caused Substituting legacy protocol with uWeave protocol to be reverted is fixed. First build showing the error: n/a Error text: n/a Original issue's description: >Revert of Substituting legacy protocol with uWeave protocol (patchset #33 id:630001 of https://codereview.chromium.org/2075313002/ ) > >Reason for revert: >This CL has a memory problem in the unit tests, as reported by DrMemory. > >First build showing the error: >https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%29/builds/5364 > >Note, that build doesn't include this change as there was a problem introduced earlier that caused the whole build to fail. > >Error text: >UNADDRESSABLE ACCESS of freed memory: reading 0x069fa848-0x069fa84c 4 byte(s) ># 0 >proximity_auth::weave::BluetoothLowEnergyWeavePacketGenerator::Factory::NewInstance [components\proximity_auth\ble\bluetooth_low_energy_weave_packet_generator.cc:33] ># 1 >proximity_auth::weave::ProximityAuthBluetoothLowEnergyWeavePacketGeneratorTest_CreateConnectionRequestTest_Test::TestBody [components\proximity_auth\ble\bluetooth_low_energy_weave_packet_generator_unittest.cc:54] ># 2 >testing::internal::HandleExceptionsInMethodIfSupported<> [testing\gtest\src\gtest.cc:2458] >Note: @0:05:46.506 in thread 13092 >Note: 0x069fa848-0x069fa84c overlaps memory 0x069fa5d8-0x069fa8c0 that was freed here: >Note: # 0 replace_operator_delete_nothrow [d:\drmemory_package\common\alloc_replace.c:2974] >Note: # 1 >proximity_auth::weave::ProximityAuthBluetoothLowEnergyWeaveClientConnectionTest_ConnectAfterADelayWhenThrottled_Test::`scalar deleting destructor' >Note: # 2 testing::Test::DeleteSelf_ [testing\gtest\include\gtest\gtest.h:453] >Note: # 3 testing::TestInfo::Run [testing\gtest\src\gtest.cc:2661] >Note: instruction: mov (%eax) -> %edx >Suppression (error hash=#E743E83C1B0FB1CF#): >For more info on using suppressions see >http://dev.chromium.org/developers/how-tos/using-drmemory#TOC-Suppressing-error-reports-from-the- >{ >UNADDRESSABLE ACCESS >name=<insert_a_suppression_name_here> >*!proximity_auth::weave::BluetoothLowEnergyWeavePacketGenerator::Factory::NewInstance >*!proximity_auth::weave::ProximityAuthBluetoothLowEnergyWeavePacketGeneratorTest_CreateConnectionRequestTest_Test::TestBody >*!testing::internal::HandleExceptionsInMethodIfSupported<> >} > >The problem is real, to fix this SetInstanceForTesting should keep the previous factory around somewhere, and there should be a method to clear the testing instance. Or something like that. BUG=617238 Review-Url: https://codereview.chromium.org/2188053003 Cr-Commit-Position: refs/heads/master@{#409618}
- Loading branch information