Fix Crash where context menu Close action is used on incognito tab

The reason for the crash was that the browser state can be destroyed and
created during the life time of the browser. (specifically when there no
incognito tabs).
The fix is to pick the value of browsing status from the existing browser
state when the helper is created.

Bug: 1206655
Change-Id: Iddbe65e78764be3e6d31da5a2f999419f060eab5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2881024
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#881126}

ios/chrome/browser/ui/tab_switcher/tab_grid/grid/grid_context_menu_helper.mm

@@ -22,10 +22,9 @@
 @interface GridContextMenuHelper () <GridContextMenuProvider>
 
 @property(nonatomic, assign) Browser* browser;
-
 @property(nonatomic, weak) id<TabContextMenuDelegate> contextMenuDelegate;
 @property(nonatomic, weak) id<GridMenuActionsDataSource> actionsDataSource;
-
+@property(nonatomic, assign) BOOL incognito;
 @end
 
 @implementation GridContextMenuHelper
@@ -41,6 +40,7 @@ - (instancetype)initWithBrowser:(Browser*)browser
     _browser = browser;
     _contextMenuDelegate = tabContextMenuDelegate;
     _actionsDataSource = actionsDataSource;
+    _incognito = _browser->GetBrowserState()->IsOffTheRecord();
   }
   return self;
 }
@@ -100,13 +100,11 @@ - (UIContextMenuConfiguration*)contextMenuConfigurationForGridCell:
         if ([weakSelf.contextMenuDelegate
                 respondsToSelector:@selector(closeTabWithIdentifier:
                                                           incognito:)]) {
-          [menuElements
-              addObject:[actionFactory actionToCloseTabWithBlock:^{
-                [weakSelf.contextMenuDelegate
-                    closeTabWithIdentifier:gridCell.itemIdentifier
-                                 incognito:weakSelf.browser->GetBrowserState()
-                                               ->IsOffTheRecord()];
-              }]];
+          [menuElements addObject:[actionFactory actionToCloseTabWithBlock:^{
+                          [weakSelf.contextMenuDelegate
+                              closeTabWithIdentifier:gridCell.itemIdentifier
+                                           incognito:weakSelf.incognito];
+                        }]];
         }
         return [UIMenu menuWithTitle:@"" children:menuElements];
       };