Skip to content

Commit

Permalink
[OsSettingsLanguages] Update to web content languages
Browse files Browse the repository at this point in the history
Language preference does not work for ARC++ apps so it's confusing to
have Languages for apps and websites. Update to Web content languages
as per UX instruction in http://screen/9BzyiPBEKPaxJ7d

Screenshot view: http://screen/BHQBr82CjccbZmv

Bug: 1140779
Change-Id: Ida3067f6a04bb09efa28c25ccf723e979873e5b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494298
Commit-Queue: My Nguyen <myy@chromium.org>
Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820437}
  • Loading branch information
My Nguyen authored and Commit Bot committed Oct 23, 2020
1 parent 97155b1 commit 1d558f2
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions chrome/app/os_settings_strings.grdp
Original file line number Diff line number Diff line change
Expand Up @@ -286,11 +286,11 @@
<message name="IDS_OS_SETTINGS_LANGUAGES_CHANGE_DEVICE_LANGUAGE_CONFIRM_BUTTON_LABEL" desc="Label for the button where users can confirm the selected language and restart the device.">
Confirm and restart
</message>
<message name="IDS_OS_SETTINGS_LANGUAGES_LANGUAGES_PREFERENCE_TITLE" desc="Title of section that lets users choose the language for apps and websites. The web content languages will be served in the order of the list.">
Languages for apps and websites
<message name="IDS_OS_SETTINGS_LANGUAGES_LANGUAGES_PREFERENCE_TITLE" desc="Title of section that lets users choose the language for web content. The web content languages will be served in the order of the list.">
Web content languages
</message>
<message name="IDS_OS_SETTINGS_LANGUAGES_LANGUAGES_PREFERENCE_DESCRIPTION" desc="Description for section that lets users choose the language for apps and websites. The web content languages will be served in the order of the list.">
Apps and websites that are available in multiple languages will use the first supported language from this list. These preferences are synced with your browser settings. <ph name="BEGIN_LINK_LEARN_MORE">&lt;a target="_blank" href="$1"&gt;</ph>Learn more<ph name="END_LINK_LEARN_MORE">&lt;/a&gt;</ph>
<message name="IDS_OS_SETTINGS_LANGUAGES_LANGUAGES_PREFERENCE_DESCRIPTION" desc="Description for section that lets users choose the language for web content. The web content languages will be served in the order of the list.">
Web content available in multiple languages will use the first supported language from this list. These preferences are synced with your browser settings. <ph name="BEGIN_LINK_LEARN_MORE">&lt;a target="_blank" href="$1"&gt;</ph>Learn more<ph name="END_LINK_LEARN_MORE">&lt;/a&gt;</ph>
</message>
<message name="IDS_OS_SETTINGS_LANGUAGES_TRANSLATE_TARGET_LABEL" desc="The label of the toggle that enables the prompt to translate a page to users.">
Language used when translating pages
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
300b1de537007bb5a5e650b54417374d864bd258
ece2fcaa558dc550264205b05352ea7e8d2dcd60
Original file line number Diff line number Diff line change
@@ -1 +1 @@
d76b317a83c1ffbcc7d96e6340c8d49ab5d375b0
ece2fcaa558dc550264205b05352ea7e8d2dcd60

0 comments on commit 1d558f2

Please sign in to comment.