Remove/replace unnecessary logging.h includes in .cc files (services)

CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved to the much smaller headers check.h, check_op.h, and notreached.h, respectively. This CL updates .cc files to use those headers instead when possible, with the purpose of saving compile time. (Split out from https://crrev.com/c/2164525 which also has notes on how the change was generated.) Bug: 1031540 Change-Id: Ib76c48802119bb3d17cd0268adf1ef64b1895593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164615 Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#762961}
FairyWorld · Apr 27, 2020 · 1be837b · 1be837b
1 parent 799414f
commit 1be837b
Show file tree

Hide file tree

Showing 128 changed files with 134 additions and 128 deletions.
diff --git a/services/audio/output_controller_unittest.cc b/services/audio/output_controller_unittest.cc
@@ -13,11 +13,12 @@
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback_helpers.h"
+#include "base/check.h"
 #include "base/environment.h"
 #include "base/location.h"
-#include "base/logging.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
+#include "base/notreached.h"
 #include "base/optional.h"
 #include "base/run_loop.h"
 #include "base/single_thread_task_runner.h"

diff --git a/services/audio/public/cpp/audio_system_to_service_adapter.cc b/services/audio/public/cpp/audio_system_to_service_adapter.cc
@@ -7,8 +7,9 @@
 #include <utility>
 
 #include "base/bind.h"
-#include "base/logging.h"
+#include "base/check_op.h"
 #include "base/metrics/histogram_macros.h"
+#include "base/notreached.h"
 #include "base/trace_event/trace_event.h"
 #include "media/audio/audio_device_description.h"
 #include "mojo/public/cpp/bindings/callback_helpers.h"

diff --git a/services/audio/public/cpp/sounds/sounds_manager_unittest.cc b/services/audio/public/cpp/sounds/sounds_manager_unittest.cc
@@ -8,7 +8,6 @@
 
 #include "base/bind_helpers.h"
 #include "base/compiler_specific.h"
-#include "base/logging.h"
 #include "base/run_loop.h"
 #include "base/stl_util.h"
 #include "base/strings/string_piece.h"

diff --git a/services/audio/public/cpp/sounds/test_data.cc b/services/audio/public/cpp/sounds/test_data.cc
@@ -4,7 +4,6 @@
 
 #include "services/audio/public/cpp/sounds/test_data.h"
 
-#include "base/logging.h"
 #include "base/threading/thread_task_runner_handle.h"
 
 namespace audio {

diff --git a/services/audio/service.cc b/services/audio/service.cc
@@ -8,8 +8,8 @@
 #include <utility>
 
 #include "base/bind.h"
+#include "base/check_op.h"
 #include "base/deferred_sequenced_task_runner.h"
-#include "base/logging.h"
 #include "base/macros.h"
 #include "base/no_destructor.h"
 #include "base/single_thread_task_runner.h"

diff --git a/services/audio/test/fake_consumer.cc b/services/audio/test/fake_consumer.cc
@@ -9,8 +9,8 @@
 #include <memory>
 #include <utility>
 
+#include "base/check_op.h"
 #include "base/files/file.h"
-#include "base/logging.h"
 #include "base/numerics/math_constants.h"
 #include "base/task/thread_pool/thread_pool_instance.h"
 #include "base/test/task_environment.h"

diff --git a/services/data_decoder/image_decoder_impl.cc b/services/data_decoder/image_decoder_impl.cc
@@ -8,7 +8,6 @@
 
 #include <utility>
 
-#include "base/logging.h"
 #include "mojo/public/cpp/bindings/strong_binding.h"
 #include "skia/ext/image_operations.h"
 #include "third_party/blink/public/platform/web_data.h"

diff --git a/services/device/battery/battery_status_manager_default.cc b/services/device/battery/battery_status_manager_default.cc
@@ -6,8 +6,8 @@
 
 #include <memory>
 
-#include "base/logging.h"
 #include "base/macros.h"
+#include "base/notreached.h"
 
 namespace device {
 

diff --git a/...bsolute_orientation_euler_angles_fusion_algorithm_using_accelerometer_and_magnetometer.cc b/...bsolute_orientation_euler_angles_fusion_algorithm_using_accelerometer_and_magnetometer.cc
@@ -6,7 +6,7 @@
 
 #include <cmath>
 
-#include "base/logging.h"
+#include "base/check.h"
 #include "base/numerics/math_constants.h"
 #include "services/device/generic_sensor/orientation_util.h"
 #include "services/device/generic_sensor/platform_sensor_fusion.h"

diff --git a/services/device/generic_sensor/linear_acceleration_fusion_algorithm_using_accelerometer.cc b/services/device/generic_sensor/linear_acceleration_fusion_algorithm_using_accelerometer.cc
@@ -4,7 +4,7 @@
 
 #include "services/device/generic_sensor/linear_acceleration_fusion_algorithm_using_accelerometer.h"
 
-#include "base/logging.h"
+#include "base/check.h"
 #include "services/device/generic_sensor/platform_sensor_fusion.h"
 
 namespace device {

diff --git a/services/device/generic_sensor/orientation_euler_angles_fusion_algorithm_using_quaternion.cc b/services/device/generic_sensor/orientation_euler_angles_fusion_algorithm_using_quaternion.cc
@@ -6,7 +6,7 @@
 
 #include <cmath>
 
-#include "base/logging.h"
+#include "base/check.h"
 #include "services/device/generic_sensor/orientation_util.h"
 #include "services/device/generic_sensor/platform_sensor_fusion.h"
 

diff --git a/services/device/generic_sensor/orientation_quaternion_fusion_algorithm_using_euler_angles.cc b/services/device/generic_sensor/orientation_quaternion_fusion_algorithm_using_euler_angles.cc
@@ -6,7 +6,7 @@
 
 #include <cmath>
 
-#include "base/logging.h"
+#include "base/check.h"
 #include "services/device/generic_sensor/generic_sensor_consts.h"
 #include "services/device/generic_sensor/platform_sensor_fusion.h"
 #include "ui/gfx/geometry/angle_conversions.h"

diff --git a/services/device/generic_sensor/orientation_util.cc b/services/device/generic_sensor/orientation_util.cc
@@ -6,7 +6,7 @@
 
 #include <cmath>
 
-#include "base/logging.h"
+#include "base/check_op.h"
 #include "base/numerics/math_constants.h"
 #include "services/device/generic_sensor/generic_sensor_consts.h"
 #include "ui/gfx/geometry/angle_conversions.h"

diff --git a/services/device/generic_sensor/platform_sensor.cc b/services/device/generic_sensor/platform_sensor.cc
@@ -7,7 +7,7 @@
 #include <utility>
 
 #include "base/bind.h"
-#include "base/logging.h"
+#include "base/check.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "services/device/generic_sensor/platform_sensor_provider.h"
 #include "services/device/generic_sensor/platform_sensor_util.h"

diff --git a/services/device/generic_sensor/platform_sensor_fusion.cc b/services/device/generic_sensor/platform_sensor_fusion.cc
@@ -7,8 +7,9 @@
 #include <algorithm>
 
 #include "base/bind.h"
-#include "base/logging.h"
+#include "base/check.h"
 #include "base/memory/scoped_refptr.h"
+#include "base/notreached.h"
 #include "services/device/generic_sensor/platform_sensor_fusion_algorithm.h"
 #include "services/device/generic_sensor/platform_sensor_provider.h"
 #include "services/device/generic_sensor/platform_sensor_util.h"

diff --git a/.../generic_sensor/relative_orientation_euler_angles_fusion_algorithm_using_accelerometer.cc b/.../generic_sensor/relative_orientation_euler_angles_fusion_algorithm_using_accelerometer.cc
@@ -6,7 +6,7 @@
 
 #include <cmath>
 
-#include "base/logging.h"
+#include "base/check_op.h"
 #include "base/numerics/math_constants.h"
 #include "services/device/generic_sensor/platform_sensor_fusion.h"
 #include "ui/gfx/geometry/angle_conversions.h"

diff --git a/...r/relative_orientation_euler_angles_fusion_algorithm_using_accelerometer_and_gyroscope.cc b/...r/relative_orientation_euler_angles_fusion_algorithm_using_accelerometer_and_gyroscope.cc
@@ -6,7 +6,7 @@
 
 #include <cmath>
 
-#include "base/logging.h"
+#include "base/check.h"
 #include "base/numerics/math_constants.h"
 #include "services/device/generic_sensor/generic_sensor_consts.h"
 #include "services/device/generic_sensor/platform_sensor_fusion.h"

diff --git a/services/device/geolocation/fake_location_provider.cc b/services/device/geolocation/fake_location_provider.cc
@@ -13,7 +13,6 @@
 #include "base/bind_helpers.h"
 #include "base/compiler_specific.h"
 #include "base/location.h"
-#include "base/logging.h"
 #include "base/memory/weak_ptr.h"
 #include "base/threading/thread_task_runner_handle.h"
 

diff --git a/services/device/geolocation/geolocation_provider_impl.cc b/services/device/geolocation/geolocation_provider_impl.cc
@@ -9,11 +9,12 @@
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
+#include "base/check.h"
 #include "base/lazy_instance.h"
 #include "base/location.h"
-#include "base/logging.h"
 #include "base/memory/ptr_util.h"
 #include "base/memory/singleton.h"
+#include "base/notreached.h"
 #include "base/single_thread_task_runner.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "base/time/default_tick_clock.h"

diff --git a/services/device/geolocation/position_cache_test_util.cc b/services/device/geolocation/position_cache_test_util.cc
@@ -6,8 +6,8 @@
 
 #include <cmath>
 
+#include "base/check_op.h"
 #include "base/guid.h"
-#include "base/logging.h"
 #include "base/strings/utf_string_conversions.h"
 
 namespace device {

diff --git a/services/device/geolocation/wifi_data.cc b/services/device/geolocation/wifi_data.cc
@@ -10,7 +10,7 @@
 #include <algorithm>
 #include <limits>
 
-#include "base/logging.h"
+#include "base/check.h"
 
 namespace device {
 

diff --git a/services/device/public/cpp/generic_sensor/platform_sensor_configuration.cc b/services/device/public/cpp/generic_sensor/platform_sensor_configuration.cc
@@ -4,7 +4,7 @@
 
 #include "services/device/public/cpp/generic_sensor/platform_sensor_configuration.h"
 
-#include "base/logging.h"
+#include "base/check_op.h"
 
 namespace device {
 

diff --git a/services/device/public/cpp/hid/hid_report_descriptor_item.cc b/services/device/public/cpp/hid/hid_report_descriptor_item.cc
@@ -6,7 +6,7 @@
 
 #include <stdlib.h>
 
-#include "base/logging.h"
+#include "base/check.h"
 
 namespace device {
 

diff --git a/services/device/public/cpp/test/fake_sensor_and_provider.cc b/services/device/public/cpp/test/fake_sensor_and_provider.cc
@@ -7,7 +7,7 @@
 #include <memory>
 #include <utility>
 
-#include "base/logging.h"
+#include "base/notreached.h"
 #include "base/time/time.h"
 #include "mojo/public/cpp/bindings/interface_request.h"
 #include "mojo/public/cpp/bindings/self_owned_receiver.h"

diff --git a/services/device/public/cpp/test/test_wake_lock_provider.cc b/services/device/public/cpp/test/test_wake_lock_provider.cc
@@ -8,7 +8,8 @@
 #include <utility>
 
 #include "base/callback.h"
-#include "base/logging.h"
+#include "base/check_op.h"
+#include "base/notreached.h"
 #include "mojo/public/cpp/bindings/receiver_set.h"
 #include "mojo/public/cpp/bindings/remote_set.h"
 

diff --git a/services/device/serial/serial_device_enumerator_linux.cc b/services/device/serial/serial_device_enumerator_linux.cc
@@ -10,7 +10,7 @@
 #include <utility>
 #include <vector>
 
-#include "base/logging.h"
+#include "base/check_op.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/threading/scoped_blocking_call.h"

diff --git a/services/device/time_zone_monitor/time_zone_monitor_chromeos.cc b/services/device/time_zone_monitor/time_zone_monitor_chromeos.cc
@@ -6,7 +6,6 @@
 
 #include <memory>
 
-#include "base/logging.h"
 #include "base/macros.h"
 #include "chromeos/settings/timezone_settings.h"
 #include "third_party/icu/source/i18n/unicode/timezone.h"

diff --git a/services/device/usb/fake_usb_device_handle.cc b/services/device/usb/fake_usb_device_handle.cc
@@ -8,8 +8,8 @@
 #include <utility>
 
 #include "base/callback.h"
-#include "base/logging.h"
 #include "base/memory/ref_counted_memory.h"
+#include "base/notreached.h"
 #include "services/device/usb/usb_device.h"
 
 namespace device {

diff --git a/services/device/wake_lock/power_save_blocker/power_save_blocker_android.cc b/services/device/wake_lock/power_save_blocker/power_save_blocker_android.cc
@@ -6,8 +6,8 @@
 
 #include "base/android/jni_android.h"
 #include "base/bind.h"
+#include "base/check.h"
 #include "base/location.h"
-#include "base/logging.h"
 #include "base/macros.h"
 #include "base/sequenced_task_runner.h"
 #include "services/device/wake_lock/power_save_blocker/jni_headers/PowerSaveBlocker_jni.h"

diff --git a/services/device/wake_lock/power_save_blocker/power_save_blocker_chromeos.cc b/services/device/wake_lock/power_save_blocker/power_save_blocker_chromeos.cc
@@ -7,10 +7,11 @@
 #include <string>
 
 #include "base/bind.h"
+#include "base/check.h"
 #include "base/location.h"
-#include "base/logging.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
+#include "base/notreached.h"
 #include "base/sequenced_task_runner.h"
 #include "chromeos/dbus/power/power_policy_controller.h"
 

diff --git a/services/device/wake_lock/power_save_blocker/power_save_blocker_win.cc b/services/device/wake_lock/power_save_blocker/power_save_blocker_win.cc
@@ -7,7 +7,7 @@
 #include <windows.h>
 
 #include "base/bind.h"
-#include "base/logging.h"
+#include "base/check.h"
 #include "base/macros.h"
 #include "base/sequenced_task_runner.h"
 #include "base/strings/utf_string_conversions.h"

diff --git a/services/metrics/public/cpp/metrics_utils.cc b/services/metrics/public/cpp/metrics_utils.cc
@@ -6,7 +6,7 @@
 
 #include <cmath>
 
-#include "base/logging.h"
+#include "base/check.h"
 #include "base/numerics/safe_conversions.h"
 
 namespace ukm {

diff --git a/services/metrics/public/cpp/mojo_ukm_recorder.cc b/services/metrics/public/cpp/mojo_ukm_recorder.cc
@@ -6,7 +6,7 @@
 
 #include <utility>
 
-#include "base/logging.h"
+#include "base/notreached.h"
 
 namespace ukm {
 

diff --git a/services/metrics/public/cpp/ukm_source.cc b/services/metrics/public/cpp/ukm_source.cc
@@ -7,8 +7,8 @@
 #include <utility>
 
 #include "base/atomicops.h"
+#include "base/check_op.h"
 #include "base/hash/hash.h"
-#include "base/logging.h"
 #include "third_party/metrics_proto/ukm/source.pb.h"
 
 namespace ukm {

diff --git a/services/metrics/public/cpp/ukm_source_id.cc b/services/metrics/public/cpp/ukm_source_id.cc
@@ -5,7 +5,7 @@
 #include "services/metrics/public/cpp/ukm_source_id.h"
 
 #include "base/atomic_sequence_num.h"
-#include "base/logging.h"
+#include "base/check.h"
 #include "base/rand_util.h"
 
 namespace ukm {

diff --git a/services/network/chunked_data_pipe_upload_data_stream.cc b/services/network/chunked_data_pipe_upload_data_stream.cc
@@ -6,8 +6,8 @@
 
 #include "base/bind.h"
 #include "base/callback.h"
+#include "base/check_op.h"
 #include "base/location.h"
-#include "base/logging.h"
 #include "mojo/public/c/system/types.h"
 #include "net/base/io_buffer.h"
 

diff --git a/services/network/cors/cors_url_loader_unittest.cc b/services/network/cors/cors_url_loader_unittest.cc
@@ -9,9 +9,10 @@
 #include <utility>
 #include <vector>
 
-#include "base/logging.h"
+#include "base/check.h"
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
+#include "base/notreached.h"
 #include "base/optional.h"
 #include "base/run_loop.h"
 #include "base/strings/string_piece.h"

diff --git a/services/network/cross_origin_read_blocking.cc b/services/network/cross_origin_read_blocking.cc
@@ -12,13 +12,14 @@
 #include <unordered_set>
 #include <vector>
 
+#include "base/check_op.h"
 #include "base/command_line.h"
 #include "base/containers/flat_set.h"
 #include "base/feature_list.h"
 #include "base/lazy_instance.h"
-#include "base/logging.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/no_destructor.h"
+#include "base/notreached.h"
 #include "base/stl_util.h"
 #include "base/strings/string_piece.h"
 #include "base/strings/string_util.h"

diff --git a/services/network/data_pipe_element_reader.cc b/services/network/data_pipe_element_reader.cc
@@ -6,8 +6,8 @@
 
 #include "base/bind.h"
 #include "base/callback.h"
+#include "base/check_op.h"
 #include "base/location.h"
-#include "base/logging.h"
 #include "mojo/public/c/system/types.h"
 #include "net/base/io_buffer.h"
 #include "net/base/net_errors.h"

diff --git a/services/network/host_resolver_unittest.cc b/services/network/host_resolver_unittest.cc
@@ -8,7 +8,7 @@
 #include <utility>
 #include <vector>
 
-#include "base/logging.h"
+#include "base/check.h"
 #include "base/optional.h"
 #include "base/run_loop.h"
 #include "base/test/bind_test_util.h"