Skip to content

Commit

Permalink
Hook up AXVisited attribute.
Browse files Browse the repository at this point in the history
BUG=58804
TEST=manually with VoiceOver.
Review URL: http://codereview.chromium.org/5751002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68806 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
dtseng@chromium.org committed Dec 10, 2010
1 parent 2020fd0 commit 1ba75e7
Showing 1 changed file with 11 additions and 7 deletions.
18 changes: 11 additions & 7 deletions chrome/browser/accessibility/browser_accessibility_cocoa.mm
Original file line number Diff line number Diff line change
Expand Up @@ -244,20 +244,24 @@ - (id)accessibilityAttributeValue:(NSString*)attribute {
return [NSNumber numberWithBool:
!GetState(browserAccessibility_, WebAccessibility::STATE_UNAVAILABLE)];
}
if ([attribute isEqualToString:@"AXVisited"]) {
return [NSNumber numberWithBool:
GetState(browserAccessibility_, WebAccessibility::STATE_TRAVERSED)];
}

// AXWebArea attributes.
if ([attribute isEqualToString:@"AXLoaded"])
return [NSNumber numberWithBool:YES];
if ([attribute isEqualToString:@"AXURL"]) {
WebAccessibility::Attribute urlAttribute =
[[self role] isEqualToString:@"AXWebArea"] ?
WebAccessibility::ATTR_DOC_URL :
WebAccessibility::ATTR_LINK_TARGET;
return NSStringForWebAccessibilityAttribute(
browserAccessibility_->attributes(),
WebAccessibility::ATTR_DOC_URL);
urlAttribute);
}

// TODO(dtseng): provide complete implementations for the following.
if ([attribute isEqualToString:@"AXVisited"])
return [NSNumber numberWithBool:NO];

// Text related attributes.
if ([attribute isEqualToString:
NSAccessibilityNumberOfCharactersAttribute]) {
Expand Down Expand Up @@ -359,14 +363,14 @@ - (NSArray*)accessibilityAttributeNames {
NSAccessibilityTopLevelUIElementAttribute,
NSAccessibilityValueAttribute,
NSAccessibilityWindowAttribute,
@"AXURL",
@"AXVisited",
nil]];

// Specific role attributes.
if ([self role] == @"AXWebArea") {
[ret addObjectsFromArray:[NSArray arrayWithObjects:
@"AXLoaded",
@"AXURL",
@"AXVisited",
nil]];
}

Expand Down

0 comments on commit 1ba75e7

Please sign in to comment.