Skip to content

Commit

Permalink
Add Mac FYI ASAN GPU split builder/tester bots
Browse files Browse the repository at this point in the history
Replacing combined buildertester "Mac FYI GPU ASAN Release" deleted in
crrev.com/c/3200452.

The split testers serialize tests, reducing the load on Mac Retina AMD
pool (as well as Mac Mini Intel pool).

Caveats for testing/buildbot/test_suite_exceptions.pyl:
1. This enables info_collection_tests suite which was previously
disabled because the old bot ran on 2 GPUs, so we couldn't give a single
expectation.
2. This doesn't add is-asan argument for passthrough variants of WebGL
tests, since this was the original state. Since we currently have some
no-asan expectations which apply to this bot, I don't want to make
changes at the moment.

Bug: 1255237
Change-Id: I0b0d0da219e211cd5fa66804add4fea85830eb3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199212
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#927511}
  • Loading branch information
y-novikov authored and Chromium LUCI CQ committed Oct 2, 2021
1 parent fabcdce commit 1931425
Show file tree
Hide file tree
Showing 17 changed files with 3,821 additions and 307 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
{
"$build/goma": {
"rpc_extra_params": "?prod",
"server_host": "goma.chromium.org",
"use_luci_auth": true
},
"$kitchen": {
"devshell": true,
"git_auth": true
},
"$recipe_engine/resultdb/test_presentation": {
"column_keys": [],
"grouping_keys": [
"status",
"v.test_suite"
]
},
"perf_dashboard_machine_group": "ChromiumGPUFYI",
"recipe": "chromium"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
"$kitchen": {
"devshell": true,
"git_auth": true
},
"$recipe_engine/resultdb/test_presentation": {
"column_keys": [],
"grouping_keys": [
"status",
"v.test_suite"
]
},
"perf_dashboard_machine_group": "ChromiumGPUFYI",
"recipe": "chromium"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
"$kitchen": {
"devshell": true,
"git_auth": true
},
"$recipe_engine/resultdb/test_presentation": {
"column_keys": [],
"grouping_keys": [
"status",
"v.test_suite"
]
},
"perf_dashboard_machine_group": "ChromiumGPUFYI",
"recipe": "chromium"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"$build/goma": {
"rpc_extra_params": "?prod",
"server_host": "goma.chromium.org",
"use_luci_auth": true
},
"$kitchen": {
"devshell": true,
"git_auth": true
},
"$recipe_engine/resultdb/test_presentation": {
"column_keys": [],
"grouping_keys": [
"status",
"v.test_suite"
]
},
"recipe": "chromium_trybot"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"$build/goma": {
"rpc_extra_params": "?prod",
"server_host": "goma.chromium.org",
"use_luci_auth": true
},
"$kitchen": {
"devshell": true,
"git_auth": true
},
"$recipe_engine/resultdb/test_presentation": {
"column_keys": [],
"grouping_keys": [
"status",
"v.test_suite"
]
},
"recipe": "chromium_trybot"
}
8 changes: 8 additions & 0 deletions infra/config/generated/luci/commit-queue.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -875,6 +875,10 @@ config_groups {
name: "chromium/try/gpu-fyi-try-mac-amd-pro-rel"
includable_only: true
}
builders {
name: "chromium/try/gpu-fyi-try-mac-amd-retina-asan"
includable_only: true
}
builders {
name: "chromium/try/gpu-fyi-try-mac-amd-retina-dbg"
includable_only: true
Expand All @@ -891,6 +895,10 @@ config_groups {
name: "chromium/try/gpu-fyi-try-mac-arm64-apple-m1-rel"
includable_only: true
}
builders {
name: "chromium/try/gpu-fyi-try-mac-intel-asan"
includable_only: true
}
builders {
name: "chromium/try/gpu-fyi-try-mac-intel-dbg"
includable_only: true
Expand Down
Loading

0 comments on commit 1931425

Please sign in to comment.