Skip to content

Commit

Permalink
fix bug "Portrait videos display body background-color during playback"
Browse files Browse the repository at this point in the history
The video recording in Android has violet the assumption of
SharedQuadState which states that the union of DrawQuads in a given
SharedQuadState is defined in |ShareQuadState::quad_layer_rect|.
This bug reveals that the VideoDrawQuad is not contained in its
SharedQuadState.

Bug: 869704

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I158275fbb321de84f7808e82b770d2f0b3cec8bc
Reviewed-on: https://chromium-review.googlesource.com/1184503
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585214}
  • Loading branch information
yiyix authored and Commit Bot committed Aug 22, 2018
1 parent fa7f8f7 commit 13de6cf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cc/layers/video_layer_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ void VideoLayerImpl::AppendQuads(viz::RenderPass* render_pass,
return;

updater_->AppendQuads(render_pass, frame_, transform, rotated_size,
visible_layer_rect(), clip_rect(), is_clipped(),
visible_quad_rect, clip_rect(), is_clipped(),
contents_opaque(), draw_opacity(),
GetSortingContextId(), visible_quad_rect);
}
Expand Down

0 comments on commit 13de6cf

Please sign in to comment.