Skip to content

Commit

Permalink
Make components explicitly declare dependencies on other components.
Browse files Browse the repository at this point in the history
BUG=314560

Review URL: https://codereview.chromium.org/62333016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234858 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
joi@chromium.org committed Nov 13, 2013
1 parent 0a8718b commit 0833f12
Show file tree
Hide file tree
Showing 6 changed files with 19 additions and 1 deletion.
5 changes: 5 additions & 0 deletions components/DEPS
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
include_rules = [
# Do not add chrome/ as an allowed include.

# Individual components must explicitly declare their dependencies
# on other components. Cycles in the dependency graph within
# components/ are not allowed.
"-components",

# Components should only depend on the public Content API, and on
# layers below the Content Module. They must not depend on the
# implementation of the Content Module.
Expand Down
9 changes: 8 additions & 1 deletion components/autofill/core/DEPS
Original file line number Diff line number Diff line change
@@ -1,9 +1,16 @@
include_rules = [
"!content/public/common/common_param_traits.h",

# TODO(joi): Perhaps PrefRegistrySyncable should be a separate
# component since it is currently in the same component as
# UserPrefs, which uses content::BrowserContext.
"+components/user_prefs/pref_registry_syncable.h",
"+components/webdata/encryptor",

# TODO(blundell): Bring this list to zero.
#
# Do not add to the list of temporarily-allowed dependencies below,
# and please do not introduce more #includes of these files.
"!content/public/common/common_param_traits.h",
"!content/public/common/common_param_traits_macros.h",
"!third_party/WebKit/public/web/WebFormElement.h",
]
1 change: 1 addition & 0 deletions components/browser_context_keyed_service/DEPS
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
include_rules = [
"+components/user_prefs",
"+content/public/browser",
]
1 change: 1 addition & 0 deletions components/dom_distiller/content/DEPS
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
include_rules = [
"+components/browser_context_keyed_service",
"+content/public/browser",
]
3 changes: 3 additions & 0 deletions components/policy/core/DEPS
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
include_rules = [
"+components/json_schema",
]
1 change: 1 addition & 0 deletions components/webdata/DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ specific_include_rules = {
"+chrome/browser/webdata/web_data_service.h",
"+chrome/browser/webdata/web_data_service_factory.h",
"+chrome/browser/webdata/web_intents_table.h",
"+components/autofill/core",
"+content/public/test",
],
}

0 comments on commit 0833f12

Please sign in to comment.