Skip to content

Commit

Permalink
chrome apps deprecation: block launch from chrome://apps page
Browse files Browse the repository at this point in the history
Bug: 1225777
Change-Id: Ifdc2faf535cd4a3337a4e6530cf662157ba3688e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3057918
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#914971}
  • Loading branch information
matt-mueller authored and Chromium LUCI CQ committed Aug 24, 2021
1 parent b1733c7 commit 022fcb5
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions chrome/browser/ui/webui/ntp/app_launcher_handler.cc
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@
#include "chrome/browser/ui/webui/ntp/new_tab_ui.h"
#include "chrome/browser/web_applications/components/web_app_constants.h"
#include "chrome/browser/web_applications/components/web_application_info.h"
#include "chrome/browser/web_applications/extension_status_utils.h"
#include "chrome/browser/web_applications/extensions/bookmark_app_util.h"
#include "chrome/browser/web_applications/web_app_icon_manager.h"
#include "chrome/browser/web_applications/web_app_install_finalizer.h"
Expand Down Expand Up @@ -743,6 +744,13 @@ void AppLauncherHandler::HandleLaunchApp(const base::ListValue* args) {

Profile* profile = extension_service_->profile();

#if defined(OS_WIN) || defined(OS_MAC) || defined(OS_LINUX)
if (extensions::IsExtensionUnsupportedDeprecatedApp(profile, extension_id)) {
// TODO(crbug.com/1225779): Show the deprecated apps dialog.
return;
}
#endif

extensions::Manifest::Type type;
GURL full_launch_url;
apps::mojom::LaunchContainer launch_container;
Expand Down

0 comments on commit 022fcb5

Please sign in to comment.