Skip to content

Add kind_config option #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 8, 2023
Merged

Conversation

rbren
Copy link
Contributor

@rbren rbren commented Feb 8, 2023

Do I need to change the docs anywhere?

Checklist

  • I have signed the CLA
  • I have updated/added any relevant documentation

Description

What's the goal of this PR?

Support kind_config param for e2e tests

What changes did you make?

Plumbed a kind_config param through

What alternative solution should we consider, if any?

Maybe there's a way to dedupe the default?

Copy link
Member

@sudermanjr sudermanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if this is going to be required to start up, we need to put it directly in the command as the default, that way even if we just use the underlying command it still works

@rbren rbren changed the base branch from master to sudermanjr/update-kind-0.16.0 February 8, 2023 17:22
@rbren rbren merged commit 34fbbc8 into sudermanjr/update-kind-0.16.0 Feb 8, 2023
@rbren rbren deleted the rb/kind-config-option branch February 8, 2023 17:52
sudermanjr added a commit that referenced this pull request Feb 8, 2023
…to 1.24 (#429)

* Update kind to 0.16.0 and update the default kube version to 1.24

* Prep 11.14 release

* shellcheck

* fix token

* Add kind_config option (#433)

* Update kubernetes_e2e_tests.yml

* Update kubernetes_e2e_tests.yml

* Update e2e_start_kind_cluster.yml

* Update e2e_start_kind_cluster.yml

* Update kubernetes_e2e_tests.yml

---------

Co-authored-by: Robert Brennan <accounts@rbren.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants