Option to skip https certificate verification #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbren
reviewed
Feb 17, 2023
cmd/polaris/audit.go
Outdated
Comment on lines
206
to
208
| client := &http.Client{Transport: &http.Transport{ | ||
| TLSClientConfig: &tls.Config{InsecureSkipVerify: true}, | ||
| }} |
There was a problem hiding this comment.
@fengshunli this is super dangerous--at most we should make this an option and turn it off by default.
|
@fengshunli can you fill out the PR template? I'm not sure what you're trying to achieve here. It might be better to provide a CA using these environment variables |
|
Because I am a self-signed certificate, I want to skip the certificate verification when uploading the result through --output-url @rbren |
|
Do I need to add a global -skip-ssl-validation set to false by default to resubmit @rbren |
|
Yup that's perfect! Thanks |
done @rbren |
rbren
reviewed
Feb 17, 2023
Signed-off-by: fengshunli <1171313930@qq.com>
|
done @rbren |
rbren
approved these changes
Feb 17, 2023
rbren
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #
Checklist
Description
What's the goal of this PR?
What changes did you make?
What alternative solution should we consider, if any?