Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to audit a directory of files #70

Merged
merged 6 commits into from
May 7, 2019
Merged

Add ability to audit a directory of files #70

merged 6 commits into from
May 7, 2019

Conversation

rbren
Copy link
Contributor

@rbren rbren commented May 2, 2019

Per request from EJ - would be great if we could use Fairwinds as part of a CI/CD process.

@rbren rbren requested review from robscott and ejether May 6, 2019 16:01
robscott
robscott reviewed May 6, 2019
View reviewed changes
Copy link
Contributor

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really promising, just had a few questions.

main.go Outdated Show resolved Hide resolved
pkg/kube/resources.go Outdated Show resolved Hide resolved
pkg/kube/resources.go Show resolved Hide resolved
robscott
robscott approved these changes May 7, 2019
View reviewed changes
Copy link
Contributor

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! I love that I can get a dashboard output for the results of a single yaml file or dir. Approved, but definitely could use a rebase.

@rbren rbren merged commit 520d657 into master May 7, 2019
@rbren rbren deleted the rb/audit-files branch May 7, 2019 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robscott robscott robscott approved these changes

@ejether ejether Awaiting requested review from ejether

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbren @robscott