Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add flag for config #50

Merged
merged 1 commit into from
Apr 9, 2019
Merged

add flag for config #50

merged 1 commit into from
Apr 9, 2019

Conversation

rbren
Copy link
Contributor

@rbren rbren commented Apr 9, 2019

No description provided.

robscott
robscott suggested changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for getting it in! I think this PR just needs to be rebased on master with a change to a .yaml.

main.go Outdated Show resolved Hide resolved
@rbren
Copy link
Contributor Author

rbren commented Apr 9, 2019

Fixed!

robscott
robscott approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks!

@sudermanjr
Copy link
Member

Should this change also be mentioned in the README?

@rbren
Copy link
Contributor Author

rbren commented Apr 9, 2019

Thanks Andy, added.

@rbren
add flag for config
a72f048 
add note to readme
@rbren rbren merged commit 8ee2f77 into master Apr 9, 2019
@sudermanjr sudermanjr deleted the config-flag branch April 10, 2019 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robscott robscott robscott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rbren @sudermanjr @robscott