Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add priority class check, some test infra #342

Merged
merged 3 commits into from
Jun 22, 2020
Merged

Add priority class check, some test infra #342

merged 3 commits into from
Jun 22, 2020

Conversation

rbren
Copy link
Contributor

@rbren rbren commented Jun 10, 2020

No description provided.

@rbren rbren mentioned this pull request Jun 10, 2020
Closed
@codecov
Copy link

codecov bot commented Jun 10, 2020 •
edited
Loading

Codecov Report

Merging #342 into master will increase coverage by 0.32%.
The diff coverage is 72.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #342      +/-   ##
==========================================
+ Coverage   53.20%   53.52%   +0.32%     
==========================================
  Files          12       12              
  Lines         718      723       +5     
==========================================
+ Hits          382      387       +5     
  Misses        283      283              
  Partials       53       53
Impacted Files Coverage Δ
pkg/validator/schema.go 76.57% <ø> (ø)
pkg/kube/resources.go 65.05% <72.41%> (+0.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cea0ca7...131561e. Read the comment docs.

baderbuddy
baderbuddy approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@baderbuddy baderbuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rbren rbren merged commit b4e3d40 into master Jun 22, 2020
@rbren rbren deleted the rb/priority-class branch June 22, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baderbuddy baderbuddy baderbuddy approved these changes

@jordandoig jordandoig Awaiting requested review from jordandoig

@makoscafee makoscafee Awaiting requested review from makoscafee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbren @baderbuddy